Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workbench.action.files.newUntitledFile #14754

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 22, 2025

What it does

Closes #14743

The Project Manager for Java extension is using the workbench.action.files.newUntitledFile to instantly create a new untitled file and then set the language of that new file to Java (other extensions do it better btw). However, our workbench.action.files.newUntitledFile implementation used to open the quick pick instead of actually creating a new untitled file.

This change just aligns the implementation of the command to VS Code

How to test

  1. Download and install the Project Manager for Java plugin
  2. Open the File menu and run New File.... Select New Java File.
  3. The file should open as expected and be correctly filled with some initial class construct.

Review checklist

Reminder for reviewers

@msujew msujew added vscode issues related to VSCode compatibility commands issues related to application commands labels Jan 22, 2025
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, once I understood how to use the new file > New java file menu ;) Thanks for this PR, @msujew!

@msujew msujew merged commit 2ee133f into master Jan 29, 2025
11 checks passed
@github-actions github-actions bot added this to the 1.58.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands issues related to application commands vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Nothing happens when chosen anything under 'New Java File'
2 participants