-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Vehicle Model Generation and kuksa-java-sdk #2
Integrate Vehicle Model Generation and kuksa-java-sdk #2
Conversation
sdk/src/main/java/org/eclipse/velocitas/sdk/databroker/v2/DataBrokerConnectorV2.kt
Outdated
Show resolved
Hide resolved
...ocessor-plugin/src/main/java/org/eclipse/velocitas/vssprocessor/plugin/VssProcessorPlugin.kt
Outdated
Show resolved
Hide resolved
6af2cc0
to
7f01a09
Compare
vss-processor/src/main/kotlin/org/eclipse/velocitas/vssprocessor/spec/VssNodeSpecModel.kt
Outdated
Show resolved
Hide resolved
Moved all kuksa.val.v2 related stuff to kuksa-java-sdk, so this PR needs to be merged first: eclipse-kuksa/kuksa-java-sdk#8 |
7f01a09
to
28bbbe1
Compare
Could we add a run config(s) for the tests? :) |
https://www.conventionalcommits.org/en/v1.0.0/ is used but the tooling is not there yet. It is fine if this is done at a later point. However two commits here are not consistent in the history. |
test-core/src/main/java/org/eclipse/velocitas/test/kotest/KotestProjectConfig.kt
Outdated
Show resolved
Hide resolved
cfec628
to
5b6a4dc
Compare
35bc617
to
3d8ec31
Compare
...ocessor-plugin/src/main/java/org/eclipse/velocitas/vssprocessor/plugin/VssProcessorPlugin.kt
Outdated
Show resolved
Hide resolved
...ocessor-plugin/src/main/java/org/eclipse/velocitas/vssprocessor/plugin/VssProcessorPlugin.kt
Show resolved
Hide resolved
...ocessor-plugin/src/main/java/org/eclipse/velocitas/vssprocessor/plugin/VssProcessorPlugin.kt
Outdated
Show resolved
Hide resolved
Functional Tests are still failing, now however with a different error message, which doesn't make sense:
I tried the following things:
Only solution I saw was to add more sample projects for the different projects (e.g. android-app, android-lib, java-app, java-lib) and add the plugin in there. |
This fixes a duplicate class error which occurs due to a clash with org.apache.tomcat:annotations-api and javax:annotations-api
8ea0b02
to
20d5726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (looks good to Mark)
Contains two bugfixes which were required for Java:
vss-processor-plugin -> VssProcessorPlugin.kt => use JavaCompile instead of preCompile (the later is an android specific gradle task)
vss-processor -> VssNodeSpecModel.kt => Change equals and hashCode method to use the path instead of the uuid. The uuid is not part of all (especially BYD-specific) VSS Specs. However the (absolute) path itself should be a sufficient id, because it will not contain two nodes which are named "Vehicle.Speed" or comparably.