Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Vehicle Model Generation and kuksa-java-sdk #2

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Jan 8, 2025

Contains two bugfixes which were required for Java:
vss-processor-plugin -> VssProcessorPlugin.kt => use JavaCompile instead of preCompile (the later is an android specific gradle task)
vss-processor -> VssNodeSpecModel.kt => Change equals and hashCode method to use the path instead of the uuid. The uuid is not part of all (especially BYD-specific) VSS Specs. However the (absolute) path itself should be a sufficient id, because it will not contain two nodes which are named "Vehicle.Speed" or comparably.

@wba2hi wba2hi changed the title Integrate vehicle model generation Integrate Vehicle Model Generation and kuksa-java-sdk Jan 8, 2025
@wba2hi wba2hi force-pushed the integrate-vehicle-model-generation branch from 6af2cc0 to 7f01a09 Compare January 8, 2025 10:17
@wba2hi wba2hi marked this pull request as draft January 9, 2025 09:11
@wba2hi
Copy link
Contributor Author

wba2hi commented Jan 10, 2025

Moved all kuksa.val.v2 related stuff to kuksa-java-sdk, so this PR needs to be merged first: eclipse-kuksa/kuksa-java-sdk#8

@wba2hi wba2hi force-pushed the integrate-vehicle-model-generation branch from 7f01a09 to 28bbbe1 Compare January 15, 2025 08:57
@wba2hi wba2hi marked this pull request as ready for review January 15, 2025 09:11
@wba2hi wba2hi closed this Jan 15, 2025
@wba2hi wba2hi reopened this Jan 15, 2025
@Chrylo
Copy link

Chrylo commented Jan 16, 2025

Could we add a run config(s) for the tests? :)

@Chrylo
Copy link

Chrylo commented Jan 16, 2025

https://www.conventionalcommits.org/en/v1.0.0/ is used but the tooling is not there yet. It is fine if this is done at a later point. However two commits here are not consistent in the history.

README.md Outdated Show resolved Hide resolved
vss-processor-plugin/build.gradle.kts Outdated Show resolved Hide resolved
@wba2hi wba2hi force-pushed the integrate-vehicle-model-generation branch from cfec628 to 5b6a4dc Compare January 16, 2025 09:53
@wba2hi wba2hi force-pushed the integrate-vehicle-model-generation branch from 35bc617 to 3d8ec31 Compare January 17, 2025 11:17
@wba2hi
Copy link
Contributor Author

wba2hi commented Jan 27, 2025

Functional Tests are still failing, now however with a different error message, which doesn't make sense:

* What went wrong:
A problem occurred configuring project ':lib'.
> Extension of type '**LibraryExtension**' does not exist. Currently registered extension types: [ExtraPropertiesExtension, LibrariesForLibs, VersionCatalogsExtension, BasePluginExtension, DefaultArtifactPublicationSet, SourceSetContainer, ReportingExtension, JavaToolchainService, JavaPluginExtension, **LibraryExtension**, LibraryAndroidComponentsExtension, NamedDomainObjectContainer<BaseVariantOutput>, VssProcessorPluginExtension]

I tried the following things:

  • add more kotlin / android related libraries as dependencies
  • add the libs from above to the buildSrc directory
  • executing the functionalTest project manually which interestingly worked but lead to a lot of uncleaned gradle .lock files which made issues on consecutive runs and had to be removed manually
  • using different packages for AppExtension and LibraryExtension

Only solution I saw was to add more sample projects for the different projects (e.g. android-app, android-lib, java-app, java-lib) and add the plugin in there.

@wba2hi wba2hi force-pushed the integrate-vehicle-model-generation branch from 8ea0b02 to 20d5726 Compare January 27, 2025 09:00
Copy link

@Chrylo Chrylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks good to Mark)

@MP91 MP91 merged commit b4e7cce into eclipse-velocitas:main Jan 27, 2025
4 checks passed
@wba2hi wba2hi deleted the integrate-vehicle-model-generation branch January 27, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants