Unify Metrics TCK logic #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce BaseMetricsTest to encapsulate shared code Make JVM metrics use in-memory exporter rather than logging Update application metrics test to use base class Remove redundant code Clean up existing code, simplifying lambdas Remove == equality check on strings Fix constant names to make checkstyle happy
jasondlee
force-pushed
the
metrics_tck_unify
branch
from
8b6dd2d to
cfce7fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce BaseMetricsTest to encapsulate shared code Make JVM metrics use in-memory exporter rather than logging Update application metrics test to use base class
Remove redundant code
Clean up existing code, simplifying lambdas
Remove == equality check on strings
Fix constant names to make checkstyle happy
Resolves #258