Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LUMI-G to build-hpc CI workflow #182

Merged
merged 9 commits into from
Jan 22, 2025
Merged

Conversation

reuterbal
Copy link
Contributor

No description provided.

@reuterbal reuterbal force-pushed the feature/ci-hpc-updates branch 6 times, most recently from 4b780da to f1a9fc0 Compare December 12, 2024 09:01
@reuterbal reuterbal force-pushed the feature/ci-hpc-updates branch 8 times, most recently from 335005b to 920d4e3 Compare December 20, 2024 14:39
@samhatfield samhatfield force-pushed the feature/ci-hpc-updates branch 16 times, most recently from 48ea913 to 654a6ab Compare January 8, 2025 14:46
@samhatfield samhatfield force-pushed the feature/ci-hpc-updates branch 8 times, most recently from a41e49c to 73386e2 Compare January 22, 2025 14:49
@samhatfield samhatfield force-pushed the feature/ci-hpc-updates branch from 73386e2 to 78d0843 Compare January 22, 2025 14:54
@samhatfield samhatfield changed the title [DRAFT] Test HPC CI Add LUMI-G to build-hpc CI workflow Jan 22, 2025
@samhatfield samhatfield marked this pull request as ready for review January 22, 2025 15:06
@samhatfield
Copy link
Collaborator

I think this is ready for merging now. For now we have limited the tests that are run on LUMI-G, basically excluding everything but the install and SETUP_TRANS0 tests. We have outstanding issues with running on AMD GPUs which are outside of the remit of this PR. Once those are resolved, we can start testing properly on LUMI-G.

I think there are probably a few things which could be tidied up with this PR. If anyone can think of a neater way of passing toolchain-like info (OpenMP_C_LIB_NAMES stuff etc.) then please suggest alternatives.

In fact, I just realised that we can probably at least do the CPU tests on LUMI-G. Let me try that.

Copy link
Contributor Author

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, many thanks for bringing this over the line @samhatfield !

I agree that it's useful to bring it in like this and do the fixing of the actual tests separately.

Also, I think specifying the toolchain-like options like this is fine. The fact that this is required in the first place is painful by itself and should be an exception, but the generic templating mechanism to pass around cmake options as part of the matrix is definitely useful!

Unfortunately, I can't approve the PR as I'm the original author 😆

@samhatfield
Copy link
Collaborator

samhatfield commented Jan 22, 2025

I relaxed the test filter so only "*gpu*" tests are filtered. The remaining all work. So now we are at least testing something meaningful!

By the way, the work directories for each CI run are still left behind on LUMI-G. That's fine but at some point we need to figure out how to clean them up automatically.

Copy link
Collaborator

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all great! Hopefully we can get the GPU configuration working soon as well.

@samhatfield samhatfield force-pushed the feature/ci-hpc-updates branch 2 times, most recently from 56c43b5 to 695f27d Compare January 22, 2025 17:22
@samhatfield samhatfield force-pushed the feature/ci-hpc-updates branch from 695f27d to ddda92b Compare January 22, 2025 17:29
@samhatfield samhatfield merged commit 87b6850 into develop Jan 22, 2025
22 of 23 checks passed
@samhatfield samhatfield deleted the feature/ci-hpc-updates branch January 22, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants