-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LUMI-G to build-hpc CI workflow #182
Conversation
4b780da
to
f1a9fc0
Compare
335005b
to
920d4e3
Compare
48ea913
to
654a6ab
Compare
a41e49c
to
73386e2
Compare
Co-authored-by: Balthasar Reuter <[email protected]>
Co-authored-by: Balthasar Reuter <[email protected]>
Co-authored-by: Balthasar Reuter <[email protected]>
73386e2
to
78d0843
Compare
I think this is ready for merging now. For now we have limited the tests that are run on LUMI-G, basically excluding everything but the install and I think there are probably a few things which could be tidied up with this PR. If anyone can think of a neater way of passing toolchain-like info ( In fact, I just realised that we can probably at least do the CPU tests on LUMI-G. Let me try that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, many thanks for bringing this over the line @samhatfield !
I agree that it's useful to bring it in like this and do the fixing of the actual tests separately.
Also, I think specifying the toolchain-like options like this is fine. The fact that this is required in the first place is painful by itself and should be an exception, but the generic templating mechanism to pass around cmake options as part of the matrix is definitely useful!
Unfortunately, I can't approve the PR as I'm the original author 😆
I relaxed the test filter so only "*gpu*" tests are filtered. The remaining all work. So now we are at least testing something meaningful! By the way, the work directories for each CI run are still left behind on LUMI-G. That's fine but at some point we need to figure out how to clean them up automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all great! Hopefully we can get the GPU configuration working soon as well.
56c43b5
to
695f27d
Compare
695f27d
to
ddda92b
Compare
No description provided.