ENH: Refactored wgribencode.F90 to extract field data linearization #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic The logic for linearizing field data has been removed from the wgribencode function and refactored into a separate subroutine. This subroutine is now called by wgribencode. The refactoring was necessary to avoid code duplication, as the IO server also requires field data linearization for Wave data.
|
|
awnawab
approved these changes
Jan 20, 2025
wdeconinck
added a commit
that referenced
this pull request
Jan 20, 2025
* release/1.4.1: (124 commits) Version 1.4.1 ENH: Refactored wgribencode.F90 to extract field data linearization logic (#58) add test on output times to match source term time stepping and define MIJ when no call to source term integration Add fp-model=strict for stresso.F90 to prevent SIGFPE with newer Intel compilers. Loki: Remove deprecated `DIRECTIVE` option in Loki CMake macro call Add default compiler flags for Cray (#50) NVHPC: downgrade optimisation for W_MAXH WAVEMDL: fix bounds checking bug fix noise level for better MWP estimate under sea ice bug fix for outwspec.F90 for when NPROC > NANG*NFRE_RED test change to outwspec.F90 debugging debug problem with call to MPL_ALLTOALLV in outwspec.F90 correct calling of w_maxh fix issue with windesea directional spread when no windsea detected correct rearrngsar.F90 for JP = 0 cases debug debug debug IFS-49R2-SYNC: set LWVFLX_SNL to TRUE ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for linearizing field data has been removed from the wgribencode function and refactored into a separate subroutine. This subroutine is now called by wgribencode. The refactoring was necessary to avoid code duplication, as the IO server also requires field data linearization for Wave data.