Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better prepml support #89

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Better prepml support #89

merged 5 commits into from
Jan 13, 2025

Conversation

b8raoult
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (1187d78) to head (0b6390a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #89   +/-   ##
========================================
  Coverage    98.03%   98.03%           
========================================
  Files            3        3           
  Lines           51       51           
========================================
  Hits            50       50           
  Misses           1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HCookie
HCookie previously approved these changes Jan 6, 2025
Copy link
Member

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has fixed most of the grib issues I was having. Any other prepml/grib fixes/features we need? Otherwise I say we can merge this one.

@gmertes gmertes merged commit 05d5e6f into develop Jan 13, 2025
118 checks passed
@gmertes gmertes deleted the feature/prepml-support branch January 13, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants