Allow zero-sized interpolation target functionspace #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odlomax
changed the title
wdeconinck
approved these changes
Jun 7, 2024
That's all we can do, really! I think the main hurdle was tweaking the adjoint checks so that they're not over reliant on checking for a matrix. I suspect we're the only folks who use that functionally. |
wdeconinck
force-pushed
the
bugfix/allow_zero_sized_interpolation_target_functionspace
branch
from
6c1a464 to
5fada06
Compare
|
@odlomax Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Atlas issue #205, and is needed for jcsda/oops issue #2264.
The SphericalVector and Structured2D interpolation methods can now be called with empty target functionspaces. Also tested are the finite-element and cubedsphere interpolation methods.