New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env): improve env detection compatibility for Node #1111

Open

liamjones wants to merge 1 commit into ecomfe:master from liamjones:improve-nodejs-detection

liamjones commented Jan 6, 2025

The React Native test environment is Node but sets up a window global: https://github.com/facebook/react-native/blob/7a85b911254dbae9fac4c6d8a862a20c33e0b36a/packages/react-native/Libraries/Core/setUpGlobals.js#L18

Reintroduce the navigator.userAgent check as a fallback for detecting a Node environment


          fix(env): improve env detection compatibility for Node

f71100c

The React Native test environment *is* Node but sets up a window global: https://github.com/facebook/react-native/blob/7a85b911254dbae9fac4c6d8a862a20c33e0b36a/packages/react-native/Libraries/Core/setUpGlobals.js#L18

Reintroduce the navigator.userAgent check as a fallback for detecting a Node environment

Author

liamjones commented Jan 6, 2025

Without this tests in an RN environment fall over on this line:

zrender/src/core/env.ts

Line 90 in ae8cfaa

const style = document.documentElement.style;

As there's a window but no document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet