Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of this project, possibility of donation to the PSF? #58

Open
di opened this issue Apr 21, 2022 · 7 comments
Open

Status of this project, possibility of donation to the PSF? #58

di opened this issue Apr 21, 2022 · 7 comments

Comments

@di
Copy link

di commented Apr 21, 2022

Hi @ecordell, first, thanks for this project, it's been very useful in a number of places. Specifically, you might be unaware, but PyPI itself uses pymacaroons to generate its API tokens, and as such this is a fairly important dependency for PyPI.

Since it looks like this library is unmaintained, I wanted to see if you'd be interested in donating it to an organization managed by the Python Software Foundation, to ensure it is maintainable by others and stays maintained. This would be either to https://github.com/psf or https://github.com/pypa depending on where it makes the most sense for us.

Feel free to respond here or email me at [email protected] if you prefer. Thanks!

(cc @jugmac00)

@ewdurbin
Copy link

ewdurbin commented Apr 21, 2022

Hi! I'm Director of Infrastructure of the Python Software Foundation, and manage the psf organization on GitHub.

This project absolutely qualifies as being "of critical nature to a Python Software Foundation maintained project such as PyPI." per our requirements for psf org transfer.

One requirement we need to ensure is the three existing maintainers. @di would you be offering to act as a maintainer of the project? I would also offer to participate as a maintainer as long as we have a third either in the current maintainer or an active contributor that is approved by the current maintainer.

@ecordell
Copy link
Owner

I don't consider pymacaroons unmaintained - I can and do review any PRs that come in - though it's true that I am not actively doing new work or vetting dependency updates (I am also wary of breaking a stable library).

I don't mind transferring to PSF and would be willing to act as one of the three maintainers required to donate it, but I'm not familiar with the process.

@di
Copy link
Author

di commented Apr 21, 2022

@ecordell That's great to hear. I don't have any specific requests for changes to the library's functionality itself, but it would be good to CI passing, possibly migrated to GitHub Actions if you're open to it, and testing against & declared compatible with the latest Python versions. If you think we can do that here I don't see an explicit need to donate it.

@jugmac00
Copy link
Contributor

jugmac00 commented Apr 22, 2022

I had a quick look at the PR to use pytest (#54). There are a couple of things missing, like a working test discovery and some more minor things.

It is straightforward to make pytest work, up to and including Python 3.9. On Python 3.10 the pinned version of hypothesis does no longer work, and newer versions of hypothesis updated the API and require changes to the tests, so I would suggest to split the updating process at least into two steps:

  • updating supported Python versions up to Python 3.9, updating tox.ini, setup.py, adding github actions...
  • adding support for Python 3.10

I'd volunteer to create a PR. There should be some consent what would be the minimum supported Python version.

We do use the library at work, so I am happy that there is a chance that this library will be updated for newer Python versions.

I'd also be able to spend some time to keep CI working / updating to newer Python versions.

That said, I'd really appreciate if a couple of more maintainers could be added to this library. Also I think the donation to psf/pypa would be a great idea.

P.S.: see #59

@jugmac00
Copy link
Contributor

@ecordell With #59 I did a first step to bring back a working CI and to enable support for newer and more current Python versions. As this was done already 10 months ago, do you think it would sense to add e.g. @di as another maintainer?

@jugmac00
Copy link
Contributor

jugmac00 commented Jan 7, 2025

Bumping this, to restart the discussion about donating the project to psf/pypa or at very least adding additional maintainers, as e.g. upgrading to newer Python versions (see #67) is blocked already for 3 months. @di / @ecordell / @ewdurbin

@lengau
Copy link

lengau commented Jan 7, 2025

If the blocker is looking for another maintainer I'm happy to step up there. This package is pretty important for my team, so if I can help ease the burden I'm happy to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants