Modernize Python support #59
Merged
+137
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Oct 29, 2022
This revision bump backports parts of the upstream PR gentoo#59 related to nose to pytest transition. Additionally, py3.11 support is enabled. Upstream-PR: ecordell/pymacaroons#59 Signed-off-by: Petr Vaněk <[email protected]>
arkamar
added a commit
to arkamar/pymacaroons
that referenced
this pull request
Oct 29, 2022
Only parts related to nose to pytest transition are backported. Backported-from: ecordell#59
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Oct 29, 2022
This revision bump applies patch which backports parts of the upstream PR gentoo#59 related to nose to pytest transition. Additionally, py3.11 support is enabled. Upstream-PR: ecordell/pymacaroons#59 Signed-off-by: Petr Vaněk <[email protected]>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Oct 29, 2022
This revision bump applies patch which backports parts of the upstream PR gentoo#59 related to nose to pytest transition. Additionally: - py3.11 support is enabled - update DESCRIPTION Upstream-PR: ecordell/pymacaroons#59 Co-authored-by: Michał Górny <[email protected]> Signed-off-by: Petr Vaněk <[email protected]>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Oct 29, 2022
This revision bump applies patch which backports parts of the upstream PR gentoo#59 related to nose to pytest transition. Additionally: - py3.11 support is enabled - update DESCRIPTION Upstream-PR: ecordell/pymacaroons#59 Co-authored-by: Michał Górny <[email protected]> Signed-off-by: Petr Vaněk <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 29, 2022
This revision bump applies patch which backports parts of the upstream PR #59 related to nose to pytest transition. Additionally: - py3.11 support is enabled - update DESCRIPTION Upstream-PR: ecordell/pymacaroons#59 Co-authored-by: Michał Górny <[email protected]> Signed-off-by: Petr Vaněk <[email protected]> Closes: #28022 Signed-off-by: Michał Górny <[email protected]>
ecordell
approved these changes
Mar 1, 2023
| push: | ||
| pull_request: | ||
| schedule: | ||
| - cron: '0 12 * * 0' # run once a week on Sunday |
There was a problem hiding this comment.
why run once a week if there have been no changes?
There was a problem hiding this comment.
Because of #60 - my PR was green a year ago when I created it, but there will be changes which break CI, e.g. updated dependencies, transitive dependencies or updated system packages / os. It is just a best practice to run CI jobs weekly to fix such breakages in a timely manner, and not e.g. when one needs to fix an urgent security issue.
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first start.
hypothesiswhich needs some tests to be rewrittenhypothesisto the latest compatible versionAlso see discussion at #58
Given this PR gets merged, there should be follow-up PRs with adding back coverage report and adding support for Python 3.10 and possibly for dropping support for obsolete Python versions.