macOS: clear runstate dir after instance stop #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
reviewed
Jan 23, 2025
mmastrac
reviewed
Jan 24, 2025
src/portable/macos.rs
Outdated
|
|
||
| // Clear the runstate dir - macOS wouldn't delete UNIX domain socket | ||
| // files after server shutdown, which may lead to issues in upgrades | ||
| fs::remove_dir_all(runstate_dir(name)?).ok(); |
There was a problem hiding this comment.
I think we should filter and remove only domain sockets if that is the problem. Something like this?
for entry in fs::read_dir(dir_path)? {
let entry = entry?;
let path = entry.path();
if let Ok(metadata) = path.metadata() {
if metadata.file_type().is_socket() {
fs::remove_file(&path)?;
}
}
}
There was a problem hiding this comment.
Yup, that'll do! Do you mind pushing that to the PR? I'm kinda in the middle of home moving. Thank you!
msullivan
approved these changes
Jan 27, 2025
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs edgedb/edgedb#8248, #1418
Manually tested with the repro in #1418