Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document withCodecs() #1164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document withCodecs() #1164

wants to merge 1 commit into from

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Jan 12, 2025

No description provided.

@1st1 1st1 marked this pull request as ready for review January 12, 2025 22:04
Returns a new ``Client`` instance with customized mapping of EdgeDB
to JavaScript types.

For example, supposed we define a custom scalar type in our schema:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example, supposed we define a custom scalar type in our schema:
For example, suppose we define a custom scalar type in our schema:

Comment on lines +520 to +521
Then in JavaScript we can customize how values of this type will
be be represented:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then in JavaScript we can customize how values of this type will
be be represented:
Then, in JavaScript, we can customize how values of this type will
be be represented:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also

Suggested change
Then in JavaScript we can customize how values of this type will
be be represented:
Then, in JavaScript, we can customize how values of this type will
be represented:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants