Make CLI wrapper install quieter #1177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Do not prompt for confirmation when installing the CLI, even for TTYs 2. More gracefully handle errors from the CLI. `stderr` is already being piped to the parent process, so no need to log errors so loudly.
Use the `Result` type to gracefully handle errors from the CLI.
scotttrinh
commented
Jan 17, 2025
packages/driver/src/cli.mts
Outdated
| error: Error & SpawnSyncReturns<string | Buffer>; | ||
| } | ||
|
|
||
| type Result = Ok | Err; |
There was a problem hiding this comment.
I could've made this generic, but... Yeah, maybe let me make this generic 🙈
scotttrinh
force-pushed
the
quieter-cli-wrapper
branch
from
d2fb314 to
6bc3f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stderris already beingpiped to the parent process, so no need to log errors so loudly.