Refactor fetching & matching packages from index into own file #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarsonF
force-pushed
the
refactor/packages
branch
2 times, most recently
from
f55f323 to
f8cffdc
Compare
|
I'm not sure why nightly is failing. I'd like to think it's unrelated to these changes. Is nightly tested on |
CarsonF
force-pushed
the
refactor/packages
branch
2 times, most recently
from
55ad4e4 to
f6e7c9d
Compare
CarsonF
force-pushed
the
refactor/packages
branch
from
f6e7c9d to
3e000f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the work for getting the CLI download url into a separate packages file.
There was some duplicated work in
win.tsthat I either DRY-ed up or unified into the linux/osx code paths.I enhanced the package index logic to work for any packages within the index,
as the test suite proves with
edgedb-server-3.I know this isn't immediately useful, but it seemed like the right thing to do.
Now only the highest level function knows about the cli package.