-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to gel #39
base: main
Are you sure you want to change the base?
Rename to gel #39
Conversation
downloadUrl | ||
]) | ||
await checkOutput('wsl chmod +x /usr/bin/edgedb') | ||
await checkOutput('wsl chmod +x /usr/bin/gel') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure these paths should be updated. In JS we run tests only on ubuntu.
Won't this break existing projects that use this action? If I would want to fix something in edgedb-elixir after merging this PR, will I need to fix my CI (and project scripts used by it) as well? I'm not sure that's what we want in the end I'm not sure exactly how GitHub Actions behaves, but there are several things I'd like to clarify here:
|
@nsidnev yes I agree we should probably not update this action here. I used |
We absolutely should test this scenario during our testing of the org rename. cc @diksipav
Based on the current best practice for GitHub Actions I believe we should publish a new major version and expect that no-one uses a bare or But yeah, step 1 is to figure out what exactly happens when a GitHub action changes both orgs and is renamed. |
No description provided.