Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to gel #39

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Rename to gel #39

wants to merge 4 commits into from

Conversation

diksipav
Copy link

No description provided.

@diksipav diksipav requested a review from nsidnev January 20, 2025 17:07
downloadUrl
])
await checkOutput('wsl chmod +x /usr/bin/edgedb')
await checkOutput('wsl chmod +x /usr/bin/gel')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure these paths should be updated. In JS we run tests only on ubuntu.

@diksipav diksipav marked this pull request as draft January 20, 2025 17:09
@nsidnev
Copy link
Member

nsidnev commented Jan 20, 2025

Won't this break existing projects that use this action? If I would want to fix something in edgedb-elixir after merging this PR, will I need to fix my CI (and project scripts used by it) as well? I'm not sure that's what we want in the end

I'm not sure exactly how GitHub Actions behaves, but there are several things I'd like to clarify here:

  1. If we change the repository to gel/setup-gel, then will projects that still use edgedb/setup-edgedb break or will GitHub redirect them automatically to gel/setup-gel
  2. If it breaks on rename, then we should probably leave this action in its current state under edgedb GitHub org, just freeze it (mark as read-only) and add to the readme that the project is now called Gel and up-to-date version of this action could be found there
  3. If GitHub automatically handles those redirects correctly, then this action should keep the configuration for EdgeDB (both edgedb-server and edgedb CLI executables) on par with Gel for some time (probably a long time)

@diksipav
Copy link
Author

diksipav commented Jan 20, 2025

@nsidnev yes I agree we should probably not update this action here. I used gel for the CLI commands in my tests but reverted them now to use edgedb and the current setup-edgedb. Initially I thought that maybe there is a problem with the action, but everything works fine when using edgedb for the CLI, so I guess we can continue with that for now.

@scotttrinh
Copy link

If we change the repository to gel/setup-gel, then will projects that still use edgedb/setup-edgedb break or will GitHub redirect them automatically to gel/setup-gel

We absolutely should test this scenario during our testing of the org rename. cc @diksipav

If it breaks on rename, then we should probably leave this action in its current state under edgedb GitHub org, just freeze it (mark as read-only) and add to the readme that the project is now called Gel and up-to-date version of this action could be found there
If GitHub automatically handles those redirects correctly, then this action should keep the configuration for EdgeDB (both edgedb-server and edgedb CLI executables) on par with Gel for some time (probably a long time)

Based on the current best practice for GitHub Actions I believe we should publish a new major version and expect that no-one uses a bare or master/main specifier in their action. If they do, they'll need to update it to pin it to v1 (or better: a specific commit).


But yeah, step 1 is to figure out what exactly happens when a GitHub action changes both orgs and is renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants