Add spawnbug, clean up mapcrashfix

* Spawnbug disables a function that allows CTs to spawn in T zones
* Removed logging from mapcrashfix

gamedata/sourceforks_ghostknife.txt

@@ -0,0 +1,35 @@
+"Games"
+{
+	"csgo"
+	{
+        "Functions"
+        {
+            "CGameUI::Deactivate"
+            {
+                "signature" "CKnife::Swing"
+                "callconv"  "thiscall"
+                "return"    "void"
+                "this"      "entity"
+                "hooktype"  "raw"
+
+                "arguments"
+                {
+                    "mode"
+                    {
+                        "type"  "int"
+                    }
+                }
+            }
+        }
+        "Signatures"
+        {
+            "CKnife::Swing"
+            {
+                //  "Weapon_Knife.Hit" "Weapon_Knife.HitWall" "Player.GhostKnifeHit" "KnifeSlash"
+                //  NOT the precache function.
+                "library"   "server"
+
+            }
+        }
+    }
+}

gamedata/sourceforks_spawnbug.txt

@@ -0,0 +1,36 @@
+"Games"
+{
+	"csgo"
+	{
+        "Keys"
+        {
+			//	How many bytes to no-op.
+            //  Note we are patching a ret so this value really doesn't matter
+            "SpawnbugSize"
+            {
+                "windows" "10"
+                "linux"   "10"
+            }
+        }
+
+		"Addresses"
+		{
+			"Spawnbug"
+			{
+                "signature" "CCSPlayer::GoToViewControl"
+			}
+		}
+
+		"Signatures"
+		{
+			"CCSPlayer::GoToViewControl"
+			{
+				//  "info_player_terrorist" and "point_viewcontrol"
+                //  This should be a method that looks up both of those entity classnames.
+				"library"	"server"
+				"windows"	"\x55\x8B\xEC\x83\xE4\xF8\x83\xEC\x34\x53\x56\x8B\xF1\x57\x8B\x8E\xA4\x1B\x00\x00"
+				"linux"		"\x55\x31\xC9\x89\xE5\x57\x56\x53\x83\xEC\x4C\x8B\x5D\x08"
+			}
+		}
+	}
+}

src/scripting/include/asm_x86.sp

@@ -41,6 +41,19 @@ enum JSHORT
 	JSHORT_GE   = JSHORT_NL,
 };
 
+enum RET
+{
+	//	Return, deconstruct stack frame
+	//	Should almost always use RET_NEAR.
+	RET_NEAR	= 0xC3,
+	RET_FAR		= 0xCB,
+
+	//	Return, pop values, THEN deconstruct stack frame.
+	//	Has IMM16 value of bytes to pop.
+	RET_NPOP	= 0xC2,
+	RET_FPOP	= 0xCA
+};
+
 enum PREFIX
 {
 	PREFIX_OPERAND = 0x66,

src/scripting/sourceforks_mapcrashfix.sp

@@ -56,10 +56,6 @@ public MRESReturn GameUIDeactivate(int self, DHookParam params)
 	//	Get the player entity
 	int player = GetEntPropEnt(self, Prop_Data, "m_player");
 
-	#if DEBUG
-		PrintToServer("CGameUI::Deactivate - Player (%d)", player);
-	#endif
-
 	//	Is the player still valid/in game?
 	//	If so, handle some funky logic
 	if (player != -1)
@@ -76,10 +72,6 @@ public MRESReturn GameUIDeactivate(int self, DHookParam params)
 			//	Remove the frozen flag from the player
 			int old_flags = GetEntProp(player, Prop_Data, "m_fFlags");
 
-			#if DEBUG
-				PrintToServer("CGameUI::Deactivate - Unfreezing");
-			#endif
-
 			SetEntProp(player, Prop_Data, "m_fFlags", old_flags & (~FLAG_FROZEN));
 		}
 
@@ -92,10 +84,6 @@ public MRESReturn GameUIDeactivate(int self, DHookParam params)
 
 			SetEntProp(player, Prop_Send, "m_iHideHUD", old_flags & (~HIDE_HUD_FLAG));
 
-			#if DEBUG
-				PrintToServer("CGameUI::Deactivate - Re-Weaponing (%d)", old_weapon);
-			#endif
-
 			if (old_weapon != -1)
 				EquipPlayerWeapon(player, old_weapon);
 		}

src/scripting/sourceforks_spawnbug.sp

@@ -0,0 +1,36 @@
+#include <sourcemod>
+#include "asm_patch.sp"
+#include "sourceforks_version.sp"
+
+public Plugin myinfo = {
+	name		= "[SourceForks] [CSGO] Spawn Bug Fix",
+	author		= "EdgeGamers Development",
+	description = "Patches an issue where players are able to spawn in enemy spawn zones.",
+	version		= PLUGIN_VERSION,
+	url			= PLUGIN_WEBSITE
+}
+
+#define GAMEDATA_FILE "sourceforks_spawnbug"
+
+GameData Config;
+
+public OnPluginStart()
+{
+	PatchInit();
+
+	Config = LoadGameConfigFile(GAMEDATA_FILE);
+
+	if (GetEngineVersion() != Engine_CSGO)
+		SetFailState("This plugin is only compatible with CS:GO.");
+
+	PatchCommand("noop_spawnbug");
+
+	//  Just disable the whole thing
+	any spawnbug_patch[] = { RET_NEAR };
+	PatchFunction(Config, "Spawnbug", "SpawnbugSize", spawnbug_patch, sizeof(spawnbug_patch));
+}
+
+public OnPluginEnd()
+{
+	RecoverFunction(Config, "Spawnbug", "SpawnbugSize");
+}