- prevent option.msgOnError being cached.

edwardfxiao · May 19, 2020 · da438fa · da438fa
1 parent 6d2b13c
commit da438fa
Show file tree

Hide file tree

Showing 11 changed files with 11 additions and 11 deletions.
diff --git a/lib/components/index.js b/lib/components/index.js
diff --git a/lib/react-inputs-validation.js b/lib/react-inputs-validation.js
diff --git a/lib/react-inputs-validation.js.map b/lib/react-inputs-validation.js.map
diff --git a/lib/react-inputs-validation.min.js b/lib/react-inputs-validation.min.js
diff --git a/lib/react-inputs-validation.min.js.map b/lib/react-inputs-validation.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-inputs-validation",
-  "version": "4.4.1",
+  "version": "4.4.2",
   "description": "A react component for form inputs validation.",
   "main": "index.js",
   "repository": {

diff --git a/src/js/Inputs/Checkbox.tsx b/src/js/Inputs/Checkbox.tsx
@@ -184,7 +184,7 @@ const component: React.FC<Props> = ({
     setErr(err);
     setMsg(msg);
     validationCallback && validationCallback(err);
-  }, []);
+  }, [option.msgOnError]);
   useEffect(
     () => {
       if (validate) {

diff --git a/src/js/Inputs/Radiobox.tsx b/src/js/Inputs/Radiobox.tsx
@@ -184,7 +184,7 @@ const component: React.FC<Props> = ({
     setErr(err);
     setMsg(msg);
     validationCallback && validationCallback(err);
-  }, []);
+  }, [option.msgOnError]);
   useEffect(
     () => {
       if (validate) {

diff --git a/src/js/Inputs/Select.tsx b/src/js/Inputs/Select.tsx
@@ -282,7 +282,7 @@ const component: React.FC<Props> = ({
     setErr(err);
     setMsg(msg);
     validationCallback && validationCallback(err);
-  }, []);
+  }, [option.msgOnError]);
   /* istanbul ignore next because of https://github.com/airbnb/enzyme/issues/441 && https://github.com/airbnb/enzyme/blob/master/docs/future.md */
   useEffect(() => {
     if (typeof window !== 'undefined') {

diff --git a/src/js/Inputs/Textarea.tsx b/src/js/Inputs/Textarea.tsx
@@ -280,7 +280,7 @@ const component: React.FC<Props> = ({
     setErr(err);
     setMsg(msg);
     validationCallback && validationCallback(err);
-  }, []);
+  }, [option.msgOnError]);
   useEffect(
     () => {
       if (validate) {

diff --git a/src/js/Inputs/Textbox.tsx b/src/js/Inputs/Textbox.tsx
@@ -386,7 +386,7 @@ const component: React.FC<Props> = ({
     setErr(err);
     setMsg(msg);
     validationCallback && validationCallback(err);
-  }, []);
+  }, [option.msgOnError]);
   useEffect(
     () => {
       if (validate) {