no message

edwardfxiao · Aug 26, 2019 · df3811a · df3811a
1 parent 03f7662
commit df3811a
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 26 deletions.
diff --git a/lib/components/Textarea.js b/lib/components/Textarea.js
@@ -514,7 +514,7 @@ var component = function component(_ref) {
     setInternalValue(String(value));
   }, [value]);
   useEffect(function () {
-    if (prevInternalValue && prevInternalValue !== internalValue) {
+    if (typeof prevInternalValue !== 'undefined' && prevInternalValue !== internalValue) {
       if (option.customFunc) {
         check();
       }

diff --git a/lib/components/Textbox.js b/lib/components/Textbox.js
@@ -661,20 +661,12 @@ var component = function component(_ref) {
     setInternalValue(String(value));
   }, [value]);
   useEffect(function () {
-    if (prevInternalValue && prevInternalValue !== internalValue) {
+    if (typeof prevInternalValue !== 'undefined' && prevInternalValue !== internalValue) {
       if (option.customFunc) {
         check();
       }
     }
   }, [internalValue]);
-  useEffect(function () {
-    /* istanbul ignore if because it won't happen */
-    if ($el === null) {
-      return;
-    }
-
-    $el.current.removeAttribute('value');
-  });
   useEffect(function () {
     if (asyncObj) {
       if (asyncObj.message) {

diff --git a/lib/react-inputs-validation.js b/lib/react-inputs-validation.js
diff --git a/lib/react-inputs-validation.js.map b/lib/react-inputs-validation.js.map
diff --git a/lib/react-inputs-validation.min.js b/lib/react-inputs-validation.min.js
diff --git a/lib/react-inputs-validation.min.js.map b/lib/react-inputs-validation.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-inputs-validation",
-  "version": "3.4.3",
+  "version": "3.4.5",
   "description": "React form input validation components",
   "main": "index.js",
   "repository": {

diff --git a/src/js/Inputs/Textarea.tsx b/src/js/Inputs/Textarea.tsx
@@ -316,7 +316,7 @@ const component: React.FC<Props> = ({
   );
   useEffect(
     () => {
-      if (prevInternalValue && prevInternalValue !== internalValue) {
+      if (typeof prevInternalValue !== 'undefined' && prevInternalValue !== internalValue) {
         if (option.customFunc) {
           check();
         }

diff --git a/src/js/Inputs/Textbox.tsx b/src/js/Inputs/Textbox.tsx
@@ -396,21 +396,14 @@ const component: React.FC<Props> = ({
   );
   useEffect(
     () => {
-      if (prevInternalValue && prevInternalValue !== internalValue) {
+      if (typeof prevInternalValue !== 'undefined' && prevInternalValue !== internalValue) {
         if (option.customFunc) {
           check();
         }
       }
     },
     [internalValue],
   );
-  useEffect(() => {
-    /* istanbul ignore if because it won't happen */
-    if ($el === null) {
-      return;
-    }
-    $el.current.removeAttribute('value');
-  });
   useEffect(
     () => {
       if (asyncObj) {