-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE/HCMPRE-1438 : Updated css version for payments css #2172
Conversation
📝 WalkthroughWalkthroughThis pull request involves updating the CSS stylesheet version for the health module in two HTML files. Specifically, the version of the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
health/micro-ui/web/micro-ui-internals/packages/css/package.json
is excluded by!**/*.json
📒 Files selected for processing (2)
health/micro-ui/web/micro-ui-internals/example/public/index.html
(1 hunks)health/micro-ui/web/public/index.html
(1 hunks)
⏰ Context from checks skipped due to timeout of 10000ms (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
🔇 Additional comments (2)
health/micro-ui/web/micro-ui-internals/example/public/index.html (1)
15-15
: Clarify the discrepancy between PR title and changes.The PR title mentions "Updated css version for payments css" but the changes are updating the health CSS version. Please clarify if this is intentional or if the PR title needs to be updated.
health/micro-ui/web/public/index.html (1)
13-13
: LGTM! Version update is consistent.The CSS version update is consistent with the change in the other HTML file, maintaining synchronization across the codebase.
@@ -12,7 +12,7 @@ | |||
<title>DIGIT</title> | |||
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" /> | |||
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" /> | |||
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].39/dist/index.css" /> | |||
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].40/dist/index.css" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
❌ Referenced CSS version 0.2.40 does not exist
The version 0.2.40 of @egovernments/digit-ui-health-css is not published to npm. The latest available version is 0.2.39. Please update the version in the HTML file to use 0.2.39 or ensure version 0.2.40 is published before merging this PR.
🔗 Analysis chain
Verify the new CSS version exists and is stable.
Please ensure that version 0.2.40 of @egovernments/digit-ui-health-css is published and stable.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the CSS package version exists and is accessible
# Check if the CSS file is accessible
curl -s -I "https://unpkg.com/@egovernments/[email protected]/dist/index.css" | head -n 1
# Check package information from npm
npm view @egovernments/digit-ui-health-css versions --json
Length of output: 1084
Choose the appropriate template for your PR:
Feature PR
Feature Request
JIRA ID
Module
Description
Related Issues
Bugfix PR
Bugfix Request
JIRA ID
Module
Description
Root Cause
Related Issues
Release PR
Summary by CodeRabbit