Develop fixes #2184
Develop fixes #2184
Conversation
#2139) DUCE-212 : added fix for translation issue not rendering properly and customization for ethopia
| @@ -206,12 +206,12 @@ const UploadFile = (props) => { | |||
| textStyles={props?.textStyles} | |||
| type={props.buttonType} | |||
| /> | |||
| {props?.uploadedFiles?.map((file, index) => { | |||
| {/* {props?.uploadedFiles?.map((file, index) => { | |||
There was a problem hiding this comment.
we cant comment in develop, it would cause some issue in other modules
| userType: "EMPLOYEE", | ||
| }; | ||
| requestData.tenantId = data?.city?.code || Digit.ULBService.getStateId(); | ||
| requestData.tenantId = requestData?.city?.code || Digit.ULBService.getStateId(); |
There was a problem hiding this comment.
not sure about this change
There was a problem hiding this comment.
checked it seems fine, as we are spreading data in requestdata before that so, in any case the value of data will be present in request data.
| @@ -49,7 +49,7 @@ const EmployeeSideBar = () => { | |||
|
|
|||
| const configEmployeeSideBar = {}; | |||
| data?.actions | |||
| .filter((e) => e.url === "url") | |||
| .filter((e) => e.url === "link") | |||
There was a problem hiding this comment.
it is not required
| @@ -20,7 +20,7 @@ const getDetailsRow = ({ id, service, complaintType }) => ({ | |||
| ES_CREATECOMPLAINT_ADDRESS: [ | |||
| service.address.landmark, | |||
| Digit.Utils.getMultiRootTenant() ? `ADMIN_${service.address.locality.code}` : Digit.Utils.locale.getLocalityCode(service.address.locality, service.tenantId), | |||
| service.address.city, | |||
| `TENANT_TENANTS_PG_${service.address.city.toUpperCase()}`, | |||
There was a problem hiding this comment.
even pg shouldnt be hardcoded
|
@Tulika-eGov please check |
|
we added many css fixes as well |
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useComplaintDetails.js
Outdated
Show resolved
Hide resolved
📝 WalkthroughWalkthroughThis pull request includes multiple modifications across hooks and components. Changes involve updating how tenant details are processed in complaint-related hooks, enhancing dependency arrays and filtering logic, and introducing language awareness where needed. Other updates include refactoring employee login logic, improving localization in chart components, and adding state handling for file uploads in complaint details. Overall, the modifications aim to improve code safety, robustness, and internationalization without altering core functionalities. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant CDM as ComplaintDetailsModal
participant FS as FileService
U->>CDM: Initiate file upload
CDM->>CDM: set fileUploading = true
CDM->>FS: Upload file
FS-->>CDM: Return upload result
alt Upload fails or file too large
CDM->>CDM: Set error message
end
CDM->>CDM: set fileUploading = false
U->>CDM: Trigger menu action
CDM->>CDM: Close modal (setPopup(false))
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (2)
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useModuleTenants.js (1)
11-34: Consider refactoring to reduce code duplication.The mapping logic for both
ddrandulbarrays is nearly identical. Consider extracting the common transformation logic into a reusable function to improve maintainability.const useModuleTenants = (module, config = {}) => { const { t } = useTranslation(); + + const transformTenant = (tenant, data) => ({ + ...tenant, + ulbKey: t(`TENANT_TENANTS_${tenant?.code?.toUpperCase?.()?.replace(".", "_")}`), + ddrKey: t( + `DDR_${data.tenants + .filter((t) => t.code === tenant.code)?.[0] + ?.city?.districtTenantCode?.toUpperCase?.() + .replace(".", "_")}` + ), + }); return useQuery(["ULB_TENANTS", module], () => Digit.SessionStorage.get("initData"), { select: (data) => ({ ddr: data.modules .find((e) => e.module === module) - .tenants.map((tenant) => ({ - ...tenant, - ulbKey: t(`TENANT_TENANTS_${tenant?.code?.toUpperCase?.()?.replace(".", "_")}`), - ddrKey: t( - `DDR_${data.tenants - .filter((t) => t.code === tenant.code)?.[0] - ?.city?.districtTenantCode?.toUpperCase?.() - .replace(".", "_")}` - ), - })) + .tenants.map(tenant => transformTenant(tenant, data)) .filter((item, i, arr) => i === arr.findIndex((t) => t.ddrKey === item.ddrKey)), ulb: data.modules .find((e) => e.module === module) - .tenants.map((tenant) => ({ - ...tenant, - ulbKey: t(`TENANT_TENANTS_${tenant?.code?.toUpperCase?.()?.replace(".", "_")}`), - ddrKey: t( - `DDR_${data.tenants - .filter((t) => t.code === tenant.code)?.[0] - ?.city?.districtTenantCode?.toUpperCase?.() - .replace(".", "_")}` - ), - })), + .tenants.map(tenant => transformTenant(tenant, data)), }), ...config, }); };micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/CustomAreaChart.js (1)
170-234: Consider refactoring tooltip rendering logic.The tooltip rendering functions (
renderTooltipandrenderTooltipForLine) contain similar formatting logic. Consider extracting the common formatting logic into a utility function to improve maintainability and reduce code duplication.Example refactor:
+ const formatTooltipValue = (value, symbol, denomination, t) => { + const prefix = symbol?.toLowerCase() === "amount" && denomination === "Unit" ? " ₹" : " "; + const postfix = symbol?.toLowerCase() === "percentage" + ? " %" + : symbol?.toLowerCase() === "amount" && denomination !== "Unit" + ? t(Digit.Utils.locale.getTransformedLocale(`ES_DSS_${denomination}`)) + : ""; + + return `${prefix}${ + symbol?.toLowerCase() === "amount" + ? Digit.Utils.dss.formatter(getDenominatedValue(denomination, value), 'number', denomination, true, t) + : Digit.Utils.dss.formatter(value, 'number', denomination, true, t) + }${postfix}`; + };🧰 Tools
🪛 Biome (1.9.4)
[error] 205-206: Avoid the delete operator which can impact performance.
(lint/performance/noDelete)
[error] 206-207: Avoid the delete operator which can impact performance.
(lint/performance/noDelete)
[error] 207-208: Avoid the delete operator which can impact performance.
(lint/performance/noDelete)
[error] 209-210: Avoid the delete operator which can impact performance.
(lint/performance/noDelete)
[error] 171-171: This let declares a variable that is only assigned once.
'formattedLabel' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 172-172: This let declares a variable that is only assigned once.
'payloadObj' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 196-196: This let declares a variable that is only assigned once.
'payloadObj' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 197-197: This let declares a variable that is only assigned once.
'prefix' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 198-198: This let declares a variable that is only assigned once.
'postfix' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 204-204: This let declares a variable that is only assigned once.
'newPayload' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 208-208: This let declares a variable that is only assigned once.
'newObjArray' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (12)
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useComplaintDetails.js(1 hunks)micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useComplaintSubType.js(1 hunks)micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useInboxData.js(1 hunks)micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useLocalities.js(1 hunks)micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useModuleTenants.js(2 hunks)micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/Login/login.js(3 hunks)micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/CustomAreaChart.js(1 hunks)micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/CustomHorizontalBarChart.js(2 hunks)micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/GenericChart.js(1 hunks)micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/citizen/Create/Steps/SelectAddress.js(2 hunks)micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/ComplaintDetails.js(5 hunks)micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/CreateComplaint/index.js(1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useComplaintSubType.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/CreateComplaint/index.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/CustomAreaChart.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useComplaintDetails.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/citizen/Create/Steps/SelectAddress.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useLocalities.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/GenericChart.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useModuleTenants.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/CustomHorizontalBarChart.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/Login/login.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useInboxData.js (1)
Pattern **/*.js: check
micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/ComplaintDetails.js (1)
Pattern **/*.js: check
🪛 Biome (1.9.4)
micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/Login/login.js
[error] 150-150: This let declares a variable that is only assigned once.
'config' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 161-161: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
[error] 161-161: Avoid the use of spread (...) syntax on accumulators.
Spread syntax should be avoided on accumulators (like those in .reduce) because it causes a time complexity of O(n^2).
Consider methods such as .splice or .push instead.
(lint/performance/noAccumulatingSpread)
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useInboxData.js
[error] 50-50: This let declares a variable that is only assigned once.
'filtered' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
⏰ Context from checks skipped due to timeout of 10000ms (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
🔇 Additional comments (20)
micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/GenericChart.js (1)
114-114: LGTM! Good internationalization practice.The placeholder text is now properly internationalized using the translation function, which aligns with the application's localization standards.
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useModuleTenants.js (1)
18-18: LGTM! Safety improvements with optional chaining.The addition of optional chaining operators improves code safety by preventing potential runtime errors when accessing nested properties.
Also applies to: 31-31
micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/CustomAreaChart.js (2)
151-151: LGTM! Good localization enhancement.The addition of translation wrapper for legend text improves internationalization support.
267-279: LGTM! Good code cleanup.Removing commented-out Y-axis label code improves code maintainability.
Also applies to: 301-315
micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/Login/login.js (3)
74-77: LGTM! Improved tenant handling logic.The changes to tenant initialization and request data handling look good. The extraction of defaultTenant and the use of requestData.city.code are safe improvements.
Also applies to: 144-148
167-167: LGTM! Improved form validation.Good optimization to only check mandatory fields in the validation logic.
200-200: LGTM! Added defaultValues prop.The addition of defaultValues prop to FormComposerV2 is consistent with the new default values handling.
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useComplaintSubType.js (1)
14-14: LGTM! Good dependency array update.Adding
tto the dependency array is correct as it's used within the effect to translate menu items.micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useLocalities.js (1)
5-6: LGTM! Good i18n enhancement.Adding
languageto both the function parameters and query key ensures proper cache invalidation when the language changes.micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useComplaintDetails.js (1)
23-23: LGTM! Good removal of hardcoded value.The change correctly uses a dynamic
tenantIdwith proper formatting, addressing previous review comments about hardcoded values.micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/citizen/Create/Steps/SelectAddress.js (3)
8-8: LGTM: Language retrieval from session storageThe language retrieval from session storage is implemented correctly with proper JSON parsing.
12-12: LGTM: Improved city selection logicThe initial state for selectedCity now properly handles the case when there's only one city in the list.
38-39: LGTM: Language support in boundary localities hookThe useBoundaryLocalities hook now correctly receives translation and language parameters for proper localization.
micro-ui/web/micro-ui-internals/packages/modules/dss/src/components/CustomHorizontalBarChart.js (2)
66-66: LGTM: Enhanced plot name localizationThe plot name is now properly transformed using the locale utility before translation.
95-95: LGTM: Improved legend localizationLegend values are now properly transformed using the locale utility before translation.
micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/CreateComplaint/index.js (1)
236-236: LGTM: Added null safety for menu optionsThe dropdown now safely handles undefined menu values by providing an empty array fallback.
micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/ComplaintDetails.js (4)
95-95: LGTM: Added file upload state trackingAdded state variable to track file upload status.
111-111: LGTM: Improved file upload state managementFile upload state is properly managed with clear start and end states.
Also applies to: 120-120
504-504: LGTM: Enhanced menu stylingAdded margin adjustment to improve menu text alignment.
338-338: LGTM: Logical operation orderingThe popup is closed before initiating the assignment operation.
| code: Digit.ULBService.getStateId(), | ||
| name: Digit.Utils.locale.getTransformedLocale(`TENANT_TENANTS_${Digit.ULBService.getStateId()}`), | ||
| code: defaultTenant, | ||
| name: Digit.Utils.locale.getTransformedLocale(`TENANT_TENANTS_${defaultTenant}`), | ||
| }; | ||
|
|
||
| let config = [{ body: propsConfig?.inputs }]; |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Use const for immutable declarations.
The config variable is never reassigned, so it should be declared with const instead of let.
- let config = [{ body: propsConfig?.inputs }];
+ const config = [{ body: propsConfig?.inputs }];📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| let config = [{ body: propsConfig?.inputs }]; | |
| const config = [{ body: propsConfig?.inputs }]; |
🧰 Tools
🪛 Biome (1.9.4)
[error] 150-150: This let declares a variable that is only assigned once.
'config' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
| const defaultValues = config[0].body.reduce((acc, curr) => { | ||
| if (curr?.populators?.defaultValue) { | ||
| acc = { ...acc, [curr?.populators?.name]: curr?.populators?.defaultValue }; | ||
| } | ||
| return acc; | ||
| }, {}); |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Optimize reducer performance.
The current implementation using spread operator in the reducer could lead to O(n^2) complexity with large configs.
Consider using Object.assign for better performance:
const defaultValues = config[0].body.reduce((acc, curr) => {
if (curr?.populators?.defaultValue) {
- acc = { ...acc, [curr?.populators?.name]: curr?.populators?.defaultValue };
+ return Object.assign(acc, { [curr?.populators?.name]: curr?.populators?.defaultValue });
}
return acc;
}, {});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const defaultValues = config[0].body.reduce((acc, curr) => { | |
| if (curr?.populators?.defaultValue) { | |
| acc = { ...acc, [curr?.populators?.name]: curr?.populators?.defaultValue }; | |
| } | |
| return acc; | |
| }, {}); | |
| const defaultValues = config[0].body.reduce((acc, curr) => { | |
| if (curr?.populators?.defaultValue) { | |
| return Object.assign(acc, { [curr?.populators?.name]: curr?.populators?.defaultValue }); | |
| } | |
| return acc; | |
| }, {}); |
🧰 Tools
🪛 Biome (1.9.4)
[error] 161-161: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
[error] 161-161: Avoid the use of spread (...) syntax on accumulators.
Spread syntax should be avoided on accumulators (like those in .reduce) because it causes a time complexity of O(n^2).
Consider methods such as .splice or .push instead.
(lint/performance/noAccumulatingSpread)
micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/pgr/useInboxData.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (5)
micro-ui/web/micro-ui-internals/example/package.jsonis excluded by!**/*.jsonmicro-ui/web/micro-ui-internals/packages/modules/core/package.jsonis excluded by!**/*.jsonmicro-ui/web/micro-ui-internals/packages/modules/dss/package.jsonis excluded by!**/*.jsonmicro-ui/web/micro-ui-internals/packages/modules/pgr/package.jsonis excluded by!**/*.jsonmicro-ui/web/package.jsonis excluded by!**/*.json
📒 Files selected for processing (3)
micro-ui/web/micro-ui-internals/packages/modules/core/CHANGELOG.md(1 hunks)micro-ui/web/micro-ui-internals/packages/modules/dss/CHANGELOG.md(1 hunks)micro-ui/web/micro-ui-internals/packages/modules/pgr/CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
micro-ui/web/micro-ui-internals/packages/modules/core/CHANGELOG.md
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
micro-ui/web/micro-ui-internals/packages/modules/dss/CHANGELOG.md
2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
2-2: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
3-3: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
micro-ui/web/micro-ui-internals/packages/modules/pgr/CHANGELOG.md
2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
2-2: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
3-3: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
| ## [1.8.11] [3-Feb-2025] | ||
| - Fixed PGR issues and related found in PGR ethopia demo |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Review the new version entry details.
The new entry for version 1.8.11 is added with the description:
- Fixed PGR issues and related found in PGR ethopia demo
Consider correcting the spelling "ethopia" to "Ethiopia" and rephrasing for clarity (e.g. "Fixed PGR issues and related problems found in the PGR Ethiopia demo").
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
2-2: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
3-3: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
|
|
||
| ## [1.8.11] [3-Feb-2025] | ||
| - Fixed PGR issues and related found in PGR ethopia demo | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Improve Markdown Formatting.
Markdownlint suggests that headings and list items be surrounded by blank lines. Adding a blank line before and after headings and list items will enhance readability and compliance with MD022, MD041, and MD032.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
2-2: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
3-3: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
| ## [1.8.11] [3-Feb-2025] | ||
| - Fixed DSS issues and related found in PGR ethopia demo, and enhanced few keys related to localisations issue. |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Review the new version entry content.
The new entry for version 1.8.11 currently reads:
- Fixed DSS issues and related found in PGR ethopia demo, and enhanced few keys related to localisations issue.
Please consider:
- Correcting "ethopia" to "Ethiopia".
- Revising the phrasing (for example, "Fixed DSS issues and related problems found in the PGR Ethiopia demo and enhanced localization key settings.").
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
2-2: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
3-3: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
|
|
||
| ## [1.8.11] [3-Feb-2025] | ||
| - Fixed DSS issues and related found in PGR ethopia demo, and enhanced few keys related to localisations issue. | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Enhance Markdown Formatting.
Similar to other changelog files, adding blank lines before and after headings and lists would improve readability and adhere to markdownlint guidelines.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
2-2: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
2-2: First line in a file should be a top-level heading
null
(MD041, first-line-heading, first-line-h1)
3-3: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
| ## [1.8.22] [3-Feb-2025] | ||
| - Fixed core issues and related found in PGR ethopia demo |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Review the new core changelog entry.
The new changelog entry for version 1.8.22 states:
- Fixed core issues and related found in PGR ethopia demo
For clarity and consistency, consider:
- Correcting "ethopia" to "Ethiopia".
- Revising the phrasing to something like "Fixed core issues and related bugs identified in the PGR Ethiopia demo."
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
| # Changelog | ||
|
|
||
| ## [1.8.22] [3-Feb-2025] | ||
| - Fixed core issues and related found in PGR ethopia demo |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Improve Markdown Styling.
To comply with markdownlint guidelines (MD022, MD041, MD032), consider ensuring that all headings and list items are properly separated by blank lines. This will promote better readability and consistency across the changelog.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
1-1: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
Summary by CodeRabbit
New Features
Refactor
Bug Fixes