-
Notifications
You must be signed in to change notification settings - Fork 35
Merge pull request #212 from egovernments/QA #219
base: DEV
Are you sure you want to change the base?
Conversation
Update roleactions.json
updating hcm admin console
Update roleactions.json
Update roleactions.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- data/mz/common-masters/uiCommonConstants.json (1 hunks)
Additional comments not posted (8)
data/mz/common-masters/uiCommonConstants.json (8)
2-2
: LGTM!The
tenantId
is correctly set to "mz".
3-3
: LGTM!The
moduleName
is correctly set to "common-masters".
8-11
: LGTM!The
home
route configuration is correctly set withroutePath
andisOrigin
properties.
12-15
: LGTM!The
national
route configuration is correctly set withroutePath
,isOrigin
, andtitle
properties.
17-20
: LGTM!The
district
route configuration is correctly set withroutePath
,isOrigin
, andtitle
properties.
22-25
: LGTM!The
province
route configuration is correctly set withroutePath
,isOrigin
, andtitle
properties.
27-30
: LGTM!The
hf
route configuration is correctly set withroutePath
,isOrigin
, andtitle
properties.
32-37
: LGTM!The
hcm
route configuration is correctly set withroutePath
,isOrigin
,title
,Authorization
, andbase-kibana-path
properties.
added overwriteTimeFilter key for kibana dss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- data/mz/common-masters/uiCommonConstants.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- data/mz/common-masters/uiCommonConstants.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- data/mz/common-masters/uiCommonConstants.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- data/mz/common-masters/uiCommonConstants.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- data/mz/common-masters/uiCommonConstants.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- data/mz/common-masters/uiCommonConstants.json
Update uiCommonConstants.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- data/mz/common-masters/uiCommonConstants.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- data/mz/common-masters/uiCommonConstants.json
Update uiCommonConstants.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- data/mz/common-masters/uiCommonConstants.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- data/mz/common-masters/uiCommonConstants.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- data/mz/common-masters/uiCommonConstants.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- data/mz/common-masters/uiCommonConstants.json
Qa to Demo - pgr
Summary by CodeRabbit
New Features
MDMS_ADMIN
,LOC_ADMIN
,SYSTEM_ADMINISTRATOR
, and more.PROXIMITY_SEARCH_RANGE
andFIREBASE_CONFIG
.Bug Fixes
id
field values in boundary data for improved accuracy.Enhancements