[Fix] Separate Username from Id #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetUserByWebAuthnId function should have to create a user. Reason: The app might separate username and webauthn id (for cases where the username is editable). Thus, we can't assume that the username is known in that function
Example now works again with the expanded interface
Forgot to update func name in handlers
|
Just a few notes for me
|
|
My main question is then, what would be a better name for a function to get a user with a given id? |
|
@mstarongithub thanks for your impact! I used your solution to huge rework. At this point I gonna close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28 but with correct branch selected