Kubernetes provider: include v1alpha+ label when searching for jobs #97
Conversation
andmat900
requested review from
t-persson and
fredjn
and removed request for
a team
andmat900
force-pushed
the
20250110_i277_remove_labels
branch
from
b2df9c0 to
32f9b05
Compare
internal/kubernetes/kubernetes.go
Outdated
| var jobs v1.JobList | ||
| // Try different labels for backward compatibility: | ||
| // label id is v0 legacy, while etos.eiffel-community.github.io/id is v1alpha+ | ||
| for _, label := range []string{"id", "etos.eiffel-community.github.io/id"} { |
There was a problem hiding this comment.
The new ID should be put first, since that is what we are expecting.
There was a problem hiding this comment.
The new one is still alpha. It will increase the amount of requests for v0.
There was a problem hiding this comment.
Yes, it will increase the number of requests until the new label is ready. But having it like this will increase the number of requests after the new label is ready and we will forget to update when the new label is ready.
Adding the new label to the suite starter should also be simple enough to avoid the extra requests caused by changing the order.
internal/kubernetes/kubernetes.go
Outdated
| var jobs v1.JobList | ||
| // Try different labels for backward compatibility: | ||
| // label id is v0 legacy, while etos.eiffel-community.github.io/id is v1alpha+ | ||
| for _, label := range []string{"id", "etos.eiffel-community.github.io/id"} { |
There was a problem hiding this comment.
Perhaps also encapsulate the label iteration for loop into a separate function, e.g getJobsByIdentifier
Applicable Issues
Description of the Change
This change updates the Kubernetes provider job search with the new label
etos.eiffel-community.github.io/id. The old labelidis still kept for backward compatibility.Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu, [email protected]