Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment(Request): make identifier optional #43

Closed
wants to merge 1 commit into from
Closed

Environment(Request): make identifier optional #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/etos_lib/kubernetes/schemas/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ class EnvironmentSpec(BaseModel):
"""EnvironmentSpec is the specification of a Environment Kubernetes resource."""

name: str
suite_id: str
sub_suite_id: str
test_suite_started_id: str
suite_id: Optional[str]
sub_suite_id: Optional[str]
test_suite_started_id: Optional[str]
Comment on lines +27 to +29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not be optional.

artifact: str
context: str
priority: int = 1
Expand Down
2 changes: 1 addition & 1 deletion src/etos_lib/kubernetes/schemas/environment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class EnvironmentRequestSpec(BaseModel):

id: str
name: Optional[str] = None
identifier: str
identifier: Optional[str] = None
image: str
imagePullPolicy: str
artifact: str
Expand Down
Loading