Fix a race condition where ESR sometimes failed to start ETR (#34)

Move check for activity finished before getting environments so
that we always check for environments even if the activity is
is finished. This fixes a race condition where the activity
would finish before we've requested all environments from the
event repository.

src/etos_suite_runner/lib/suite.py

@@ -163,15 +163,15 @@ def sub_suite_environments(self):
             )
             if activity_triggered is None:
                 continue
+            activity_finished = self.__environment_activity_finished(
+                activity_triggered["meta"]["id"]
+            )
             for environment in request_environment_defined(
                 self.etos, activity_triggered["meta"]["id"]
             ):
                 if environment["meta"]["id"] not in environments:
                     environments.append(environment["meta"]["id"])
                     yield environment
-            activity_finished = self.__environment_activity_finished(
-                activity_triggered["meta"]["id"]
-            )
             if activity_finished is not None:
                 if activity_finished["data"]["activityOutcome"]["conclusion"] != "SUCCESSFUL":
                     raise EnvironmentProviderException(