Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI setup #3

Closed
8 tasks done
serg-temchenko opened this issue May 8, 2024 · 1 comment
Closed
8 tasks done

CI setup #3

serg-temchenko opened this issue May 8, 2024 · 1 comment
Assignees

Comments

@serg-temchenko
Copy link
Contributor

serg-temchenko commented May 8, 2024

In the scope of this task, a GitHub workflow should be defined with steps covering basic needs such as building, formatting, clippy, and test checks.

Added steps with:

  • - Lint .toml files, e.g. taplo lint && taplo fmt --check.
  • - Build with "try-runtime" feature, e.g. RUSTFLAGS="-D warnings" cargo build --features try-runtime.
  • - Build of the node runtime, e.g. RUSTFLAGS="-D warnings" cargo build -p polka-storage-runtime. It is possible to build the runtime with all workspace members together successfully, but it might fail if built separately, so this step is required.
  • - Build of the node with "runtime-benchmarks" feature, e.g. RUSTFLAGS="-D warnings" cargo build -p polka-storage-node --features runtime-benchmarks.
    - To catch bugs with benchmarks in Substrate, it is also required to run a simple pass on benchmarks, e.g. ./target/debug/polka-storage-node benchmark pallet --pallet "*" --extrinsic "*" --steps 2 --repeat 1 Moved to separate issue CI benchmarks test #28.
  • - Build in release mode, e.g. RUSTFLAGS="-D warnings" cargo build --release.
  • - Formatting check, e.g. cargo fmt --all -- --check.
  • - Clippy check, e.g. cargo clippy -- -D warnings.
  • - Tests check, e.g. RUSTFLAGS="-D warnings" cargo test --workspace.

Important

The sequence of running steps is important.

@aidan46
Copy link
Contributor

aidan46 commented May 8, 2024

Put up #4 to add taplo CI

@aidan46 aidan46 mentioned this issue May 13, 2024
@aidan46 aidan46 linked a pull request May 13, 2024 that will close this issue
@aidan46 aidan46 removed a link to a pull request May 13, 2024
@serg-temchenko serg-temchenko mentioned this issue May 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants