ci: Add cargo #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`taplo lint` and `taplo format`, in that order, have been add on push and pull request into any branch.
Add a configuration file for taplo so CI and local can use the same taplo rules.
Switch from Action for taplo CI to manual install and running. Use only `taplo format` and remove `taplo lint` check.
jmg-duarte
reviewed
May 13, 2024
th7nder
requested changes
May 13, 2024
th7nder
requested changes
May 14, 2024
th7nder
previously approved these changes
May 15, 2024
jmg-duarte
previously approved these changes
May 15, 2024
Yes, I branched off of the taplo branch. I'll fix the conflicts |
aidan46
dismissed stale reviews from jmg-duarte and th7nder
The merge-base changed after approval.
th7nder
previously approved these changes
May 15, 2024
jmg-duarte
reviewed
May 16, 2024
th7nder
approved these changes
May 16, 2024
serg-temchenko
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cargo CI jobs as described in #3. At the moment we have a single cargo job that runs
clippy,buildandtest.Some notes about build times on my local env:
cargo build --release: 27m48scargo build -p polka-storage-node --features runtime-benchmarks: 20m21scargo build -p polka-storage-runtime: 5m50scargo build --features try-runtime: 19m25s