ci: Add cargo

.github/workflows/ci.yaml

@@ -1,6 +1,14 @@
 name: CI
 
-on: [push, pull_request]
+on:
+  pull_request:
+    types: [labeled]
+  push:
+    branches: [develop, main]
+
+concurrency:
+  group: ${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   toml:
@@ -20,4 +28,69 @@ jobs:
         if: failure()
         run: |
           echo 'TOML is not formatted correctly'
-          echo 'Please run `taplo format`'
+          echo 'Please run taplo format'
+
+  format:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: nightly
+          components: rustfmt
+      - name: List version
+        run: |
+          cargo --version
+          cargo fmt --version
+      - name: Cargo format
+        run: cargo fmt --all -- --check
+      - name: Cargo fmt failure info
+        if: failure()
+        run: |
+          echo '.rs files are not formatted correctly'
+          echo 'Please run cargo fmt --all'
+
+  clippy_build_and_test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Cargo caching
+        uses: actions/cache@v3
+        with:
+          path: |
+            ~/.cargo/bin/
+            ~/.cargo/registry/index/
+            ~/.cargo/registry/cache/
+            ~/.cargo/git/db/
+            target/
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-${{ hashFiles('**/Cargo.toml') }}
+      - name: Install protobuf compiler
+        run: |
+          sudo apt-get update
+          sudo apt-get install protobuf-compiler
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.77.0
+          target: wasm32-unknown-unknown
+          components: clippy rust-src
+      - name: List version
+        run: |
+          cargo --version
+          cargo clippy --version
+      - name: Cargo clippy
+        run: cargo clippy --locked -q -- -D warnings
+      - name: Build with try-runtime feature
+        run: RUSTFLAGS="-D warnings" cargo build --locked -q --features try-runtime
+      - name: Build node runtime
+        run: RUSTFLAGS="-D warnings" cargo build --locked -q -p polka-storage-runtime
+      - name: Build node with runtime-benchmark feature
+        run: RUSTFLAGS="-D warnings" cargo build --locked -q -p polka-storage-node --features runtime-benchmarks
+      - name: Build in release mode
+        run: RUSTFLAGS="-D warnings" cargo build --locked -q --release
+      - name: Run tests
+        run: RUSTFLAGS="-D warnings" cargo test --locked -q --workspace
+      - name: Failure handling
+        if: failure()
+        run: |
+          echo 'Job clippy_build_and_test failed.'
+          echo 'Please check the logs for more details'

.rustfmt.toml

@@ -0,0 +1,3 @@
+edition = "2021"
+group_imports = "StdExternalCrate"
+imports_granularity = "Crate"

node/src/rpc.rs

@@ -8,7 +8,6 @@
 use std::sync::Arc;
 
 use polka_storage_runtime::{opaque::Block, AccountId, Balance, Nonce};
-
 pub use sc_rpc::DenyUnsafe;
 use sc_transaction_pool_api::TransactionPool;
 use sp_api::ProvideRuntimeApi;

node/src/service.rs

@@ -4,12 +4,6 @@
 use std::{sync::Arc, time::Duration};
 
 use cumulus_client_cli::CollatorOptions;
-// Local Runtime Types
-use polka_storage_runtime::{
-    apis::RuntimeApi,
-    opaque::{Block, Hash},
-};
-
 // Cumulus Imports
 use cumulus_client_collator::service::CollatorService;
 use cumulus_client_consensus_common::ParachainBlockImport as TParachainBlockImport;
@@ -21,9 +15,13 @@ use cumulus_client_service::{
 };
 use cumulus_primitives_core::{relay_chain::CollatorPair, ParaId};
 use cumulus_relay_chain_interface::{OverseerHandle, RelayChainInterface};
-
 // Substrate Imports
 use frame_benchmarking_cli::SUBSTRATE_REFERENCE_HARDWARE;
+// Local Runtime Types
+use polka_storage_runtime::{
+    apis::RuntimeApi,
+    opaque::{Block, Hash},
+};
 use sc_client_api::Backend;
 use sc_consensus::ImportQueue;
 use sc_executor::{HeapAllocStrategy, WasmExecutor, DEFAULT_HEAP_ALLOC_STRATEGY};

runtime/src/configs/mod.rs

@@ -49,6 +49,7 @@ use sp_consensus_aura::sr25519::AuthorityId as AuraId;
 use sp_runtime::Perbill;
 use sp_version::RuntimeVersion;
 use xcm::latest::prelude::BodyId;
+use xcm_config::{RelayLocation, XcmOriginToTransactDispatchOrigin};
 
 // Local module imports
 use super::{
@@ -60,7 +61,6 @@ use super::{
     MAXIMUM_BLOCK_WEIGHT, MICROUNIT, NORMAL_DISPATCH_RATIO, RELAY_CHAIN_SLOT_DURATION_MILLIS,
     SLOT_DURATION, UNINCLUDED_SEGMENT_CAPACITY, VERSION,
 };
-use xcm_config::{RelayLocation, XcmOriginToTransactDispatchOrigin};
 
 parameter_types! {
     pub const Version: RuntimeVersion = VERSION;

runtime/src/configs/xcm_config.rs

@@ -1,7 +1,3 @@
-use crate::{
-    AccountId, AllPalletsWithSystem, Balances, ParachainInfo, ParachainSystem, PolkadotXcm,
-    Runtime, RuntimeCall, RuntimeEvent, RuntimeOrigin, WeightToFee, XcmpQueue,
-};
 use frame_support::{
     parameter_types,
     traits::{ConstU32, Contains, Everything, Nothing},
@@ -22,6 +18,11 @@ use xcm_builder::{
 };
 use xcm_executor::XcmExecutor;
 
+use crate::{
+    AccountId, AllPalletsWithSystem, Balances, ParachainInfo, ParachainSystem, PolkadotXcm,
+    Runtime, RuntimeCall, RuntimeEvent, RuntimeOrigin, WeightToFee, XcmpQueue,
+};
+
 parameter_types! {
     pub const RelayLocation: Location = Location::parent();
     pub const RelayNetwork: Option<NetworkId> = None;

runtime/src/lib.rs

@@ -10,31 +10,27 @@ pub mod apis;
 mod configs;
 mod weights;
 
-use smallvec::smallvec;
-use sp_runtime::{
-    create_runtime_str, generic, impl_opaque_keys,
-    traits::{BlakeTwo256, IdentifyAccount, Verify},
-    MultiSignature,
-};
-
-use sp_std::prelude::*;
-#[cfg(feature = "std")]
-use sp_version::NativeVersion;
-use sp_version::RuntimeVersion;
-
 use frame_support::{
     construct_runtime,
     weights::{
         constants::WEIGHT_REF_TIME_PER_SECOND, Weight, WeightToFeeCoefficient,
         WeightToFeeCoefficients, WeightToFeePolynomial,
     },
 };
+use smallvec::smallvec;
 pub use sp_consensus_aura::sr25519::AuthorityId as AuraId;
-pub use sp_runtime::{MultiAddress, Perbill, Permill};
-
 #[cfg(any(feature = "std", test))]
 pub use sp_runtime::BuildStorage;
-
+use sp_runtime::{
+    create_runtime_str, generic, impl_opaque_keys,
+    traits::{BlakeTwo256, IdentifyAccount, Verify},
+    MultiSignature,
+};
+pub use sp_runtime::{MultiAddress, Perbill, Permill};
+use sp_std::prelude::*;
+#[cfg(feature = "std")]
+use sp_version::NativeVersion;
+use sp_version::RuntimeVersion;
 use weights::ExtrinsicBaseWeight;
 
 /// Alias to 512-bit hash when used in the context of a transaction signature on the chain.
@@ -129,13 +125,13 @@ impl WeightToFeePolynomial for WeightToFee {
 /// of data like extrinsics, allowing for them to continue syncing the network through upgrades
 /// to even the core data structures.
 pub mod opaque {
-    use super::*;
+    pub use sp_runtime::OpaqueExtrinsic as UncheckedExtrinsic;
     use sp_runtime::{
         generic,
         traits::{BlakeTwo256, Hash as HashT},
     };
 
-    pub use sp_runtime::OpaqueExtrinsic as UncheckedExtrinsic;
+    use super::*;
     /// Opaque block header type.
     pub type Header = generic::Header<BlockNumber, BlakeTwo256>;
     /// Opaque block type.

runtime/src/weights/paritydb_weights.rs

@@ -32,9 +32,10 @@ pub mod constants {
 
     #[cfg(test)]
     mod test_db_weights {
-        use super::constants::ParityDbWeight as W;
         use frame_support::weights::constants;
 
+        use super::constants::ParityDbWeight as W;
+
         /// Checks that all weights exist and have sane values.
         // NOTE: If this test fails but you are sure that the generated values are fine,
         // you can delete it.

runtime/src/weights/rocksdb_weights.rs

@@ -32,9 +32,10 @@ pub mod constants {
 
     #[cfg(test)]
     mod test_db_weights {
-        use super::constants::RocksDbWeight as W;
         use frame_support::weights::constants;
 
+        use super::constants::RocksDbWeight as W;
+
         /// Checks that all weights exist and have sane values.
         // NOTE: If this test fails but you are sure that the generated values are fine,
         // you can delete it.