-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: PoSt e2e test #699
base: develop
Are you sure you want to change the base?
Conversation
4d8a8d8
to
4bcf1ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I have questions
maat/tests/real_world.rs
Outdated
// collateral + pre_commit_deposit (1) | ||
let balance = 12_500_000_001; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: you can expose the SP/Market function that defines the value and query it here
Or at least leave a note for one of us shmucks that will do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note.
// submit_windowed_post(&client, &charlie_kp).await; | ||
// in a network with no sectors, the 1st sector is always assigned to the 1st deadline (index: 0). | ||
let deadline = Deadline::new(0, post_proof); | ||
let sector_storage = |_sector_number| Some(sector.clone()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you making a clone, inside a closure, that doesn't even care for the argument it takes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SectorStorage: Fn(SectorNumber) -> Option<ProvenSector>
-> is the trait bound.
So basically it means that the closure must be callable multiple times. Without the clone, sector_storage
ends up being FnOnce
, so a smaller guarantee thatn the Fn
.
cfa10f6
to
dd9b6b4
Compare
Description
Fixes #381, #615.
Removes hard-coded stuff from the maat and makes full e2e proving test work.
Checklist