Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting/theme functionality separation #38

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ee6ba09
First pass at pre-commit hooks
brettsmason Jan 31, 2023
475da54
Update packages
brettsmason Sep 15, 2023
6f762ad
Update package for PHPCS
brettsmason Sep 19, 2023
9abf30d
Update PHPCS comments
brettsmason Sep 19, 2023
d4453de
Bump packages and minumum node version to reflect current lts
brettsmason Sep 13, 2024
5d61ef6
Add eighteen73-blocks as a concept to test
brettsmason Sep 13, 2024
9dc185f
Add eighteen73 core barebones
brettsmason Sep 13, 2024
88c6e77
Bump PHP version to 8.2 minimum
brettsmason Sep 16, 2024
da79dda
Update create block script
brettsmason Sep 25, 2024
6d48a4f
Update namespace
brettsmason Sep 25, 2024
ebae3c4
First pass at post type/taxonomy registration
brettsmason Sep 25, 2024
bf89e59
Rename eighteen73-blocks to nebula-blocks
brettsmason Sep 26, 2024
022227d
Rename eighteen73-core to nebula-core
brettsmason Sep 26, 2024
3c6bd42
Rework structure of core and blocks to match pulsar more closely
brettsmason Sep 27, 2024
fd4e5e1
Add abstract classes for post types and taxonomies
brettsmason Sep 27, 2024
ec0cb60
Rework post type class
brettsmason Oct 18, 2024
34eb98c
Improve post type class
brettsmason Oct 18, 2024
04076e5
Move contracts to nebula core
brettsmason Nov 5, 2024
d1308c2
Updated post type and taxonomy abstract classes
brettsmason Nov 5, 2024
04b18c5
Update npm scripts
brettsmason Nov 5, 2024
7e2d4ce
Standardise npm scripts
brettsmason Nov 5, 2024
c2f175c
Use composer to autoload
brettsmason Nov 5, 2024
12c871e
Allow base path to be configured
brettsmason Nov 5, 2024
13cb8ea
Load blocks config
brettsmason Nov 5, 2024
51062c0
Update taxonomy method
brettsmason Nov 6, 2024
acbf26a
Define a development mode to avoid pattern caching
brettsmason Nov 6, 2024
5eab11c
Use postcss-preset-env
brettsmason Nov 6, 2024
3746acc
Package updates
brettsmason Nov 6, 2024
3a6d54c
Fix package.json formatting
brettsmason Nov 7, 2024
61ee1a5
Fix formatting errors
brettsmason Nov 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php_version: ['7.4', '8.0', '8.1']
php_version: ['8.2', '8.3']

steps:
- uses: actions/checkout@v2
Expand Down
17 changes: 11 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,19 @@
web/app/plugins/*
!web/app/plugins/.gitkeep
web/app/mu-plugins/*/
!web/app/mu-plugins/nebula-core
!web/app/mu-plugins/nebula-blocks
web/app/upgrade
web/app/uploads/*
!web/app/uploads/.gitkeep
web/app/libraries/*

# WordPress
web/wp
web/.htaccess

# Themes
web/app/themes/twentytwentyfour

# Logs
*.log

Expand All @@ -19,9 +23,12 @@ web/.htaccess
.env.*
!.env.example

# Node modules
node_modules

# Composer
/composer.lock
/vendor
composer.lock
vendor

# WP-CLI
wp-cli.local.yml
Expand All @@ -33,6 +40,4 @@ wp-cli.local.yml
# Caching and performance
web/app/cache
web/app/advanced-cache.php
web/app/wp-rocket-config
web/app/webp-express
/web/app/themes/twentytwentytwo
web/app/object-cache.php
2 changes: 2 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"
14 changes: 14 additions & 0 deletions .lintstaged.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"*.scss": [
"npm run lint:css"
],
"*.js": [
"npm run lint:js"
],
"*.jsx": [
"npm run lint:js"
],
"*.php": [
"./vendor/bin/phpcs --extensions=php --warning-severity=8 -s"
]
}
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
dist
build
1 change: 1 addition & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"@wordpress/prettier-config"
17 changes: 12 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
"authors": [
{
"name": "Ed Jeavons",
"email": "ed@orphans.co.uk"
"email": "ed@eighteen73.co.uk"
},
{
"name": "Brett Mason",
"email": "brett@orphans.co.uk"
"email": "brett@eighteen73.co.uk"
}
],
"keywords": [
Expand All @@ -26,20 +26,27 @@
"only": ["wpackagist-plugin/*", "wpackagist-theme/*"]
}
],
"autoload": {
"psr-4": {
"Eighteen73\\Nebula\\Core\\": "web/app/mu-plugins/nebula-core/includes/classes",
"Eighteen73\\Nebula\\Blocks\\": "web/app/mu-plugins/nebula-blocks/includes/classes"
}
},
"require": {
"php": ">=7.4",
"php": ">=8.2",
"composer/installers": "^2.2.0",
"eighteen73/nebula-tools": "^v1.1.0",
"eighteen73/orbit": "^v1.2.0",
"vlucas/phpdotenv": "^5.5",
"roots/wordpress": "^6.1",
"roots/wp-config": "1.0.0",
"wpackagist-theme/twentytwentytwo": "^1.3"
"wpackagist-theme/twentytwentyfour": "^1.2",
"johnbillion/extended-cpts": "^5.0"
},
"require-dev": {
"squizlabs/php_codesniffer": "^3.7.1",
"roave/security-advisories": "dev-latest",
"eighteen73/phpcs-composer": "^1.0",
"eighteen73/wordpress-coding-standards": "^2.0",
"eighteen73/satellite": "^1.1"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion config/application.php
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
Config::define( 'WP_DEBUG_DISPLAY', false );
Config::define( 'WP_DEBUG_LOG', false );
Config::define( 'SCRIPT_DEBUG', false );
ini_set( 'display_errors', '0' ); // PHPCS:ignore:WordPress.PHP.IniSet.display_errors_Blacklisted
ini_set( 'display_errors', '0' ); // PHPCS:ignore:WordPress.PHP.IniSet.display_errors_Disallowed

/**
* Allow WordPress to detect HTTPS when used behind a reverse proxy or a load balancer
Expand Down
3 changes: 2 additions & 1 deletion config/environments/development.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
Config::define( 'SCRIPT_DEBUG', true );
Config::define( 'DISALLOW_INDEXING', true );
Config::define( 'WP_CACHE', false );
Config::define( 'WP_DEVELOPMENT_MODE', 'all' );

ini_set( 'display_errors', '1' ); // PHPCS:ignore:WordPress.PHP.IniSet.display_errors_Blacklisted
ini_set( 'display_errors', '1' ); // PHPCS:ignore:WordPress.PHP.IniSet.display_errors_Disallowed

// Enable plugin and theme updates and installation from the admin
Config::define( 'DISALLOW_FILE_MODS', false );
Loading
Loading