Skip to content

Add PHPCS.

Add PHPCS. #38

Triggered via pull request January 9, 2025 08:15
Status Failure
Total duration 33s
Artifacts

phpcs.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 13 warnings
phpcs: tests/src/FunctionalJavascript/Views/CivicrmContactUserRelationshipTest.php#L20
Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
phpcs: tests/src/FunctionalJavascript/Views/ActivityFullcalendarViewTest.php#L23
Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
phpcs: src/SupportedEntities.php#L743
Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
phpcs: src/SupportedEntities.php#L918
Line indented incorrectly; expected 6 spaces, found 8
phpcs: src/CivicrmEntityViewsData.php#L30
Parameter $entity_field_manager has null default value, but is not marked as nullable.
phpcs: src/CivicrmEntityViewsData.php#L497
Case breaking statements must be followed by a single blank line
phpcs: src/CivicrmEntityViewsData.php#L503
Whitespace found at end of line
phpcs: src/CivicrmEntityViewsData.php#L504
Case breaking statements must be followed by a single blank line
phpcs: src/Entity/CivicrmEntity.php#L236
Missing function doc comment
phpcs: src/Access/ContactChecksumCheckAccess.php#L60
unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
phpcs
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
phpcs
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
phpcs: tests/modules/civicrm_entity_test/civicrm_entity_test.info.yml#L7
All dependencies must be prefixed with the project name, for example "drupal:"
phpcs: tests/modules/civicrm_entity_test/civicrm_entity_test.info.yml#L8
All dependencies must be prefixed with the project name, for example "drupal:"
phpcs: civicrm_entity.info.yml#L7
All dependencies must be prefixed with the project name, for example "drupal:"
phpcs: src/CivicrmEntityViewsData.php#L158
t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
phpcs: src/Entity/Sql/CivicrmEntityStorageSchema.php#L57
Empty return statement not required here
phpcs: src/CiviEntityStorage.php#L20
Unused use statement
phpcs: src/CiviEntityStorage.php#L843
Unused variable $delta.
phpcs: src/Form/CivicrmEntityForm.php#L79
\Drupal calls should be avoided in classes, use dependency injection instead
phpcs: src/Plugin/Field/FieldFormatter/CustomMultiValue.php#L34
A comma should follow the last multiline array item. Found: "list_string"
phpcs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/