Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use consistent config file within DNAm QC pipeline #293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sof202
Copy link
Collaborator

@sof202 sof202 commented Feb 4, 2025

Description

This pull request will make it so that you no longer need to have your config file in a specific place for the QC to run. Every time the config file is sourced in the Rscripts for the DNAm QC pipeline, it uses the path assigned to the $RCONFIG variable that is set in the config file you pass into the main bash script (likely named config.txt).

This helps avoid user errors that stem from not knowing what the scripts actually want (like with #291).

Issue ticket number

This pull request is to address issue: #292.

Type of pull request

  • Bug fix
  • New feature/enhancement
  • Code refactor
  • Documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code to check that it is functional
  • I have used linters to check for common sources of errors
  • I have implemented fail safes in my code to account for edge cases
  • I have made the corresponding changes to the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code Refactor]: Config file being referenced is not consistent across rmarkdown files in DNAm QC pipeline
1 participant