Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement suggestion]: add check that sampleSheet Sentrix_ID col is not in scientific notation #84

Open
ew367 opened this issue Mar 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ew367
Copy link
Collaborator

ew367 commented Mar 27, 2024

Contact Details

No response

Enhancement suggestion

the sentrix_ID col is often coerced into scientific notation by excel. This causes errors in the QC.rmd script.

possible solutions - extract sentrix_ID from basename
add a check before running calcQCmetrics script

@ew367 ew367 added the enhancement New feature or request label Mar 27, 2024
@sof202
Copy link
Collaborator

sof202 commented Mar 28, 2024

If excel is converting IDs into scientific notation it might be truncating the value if the IDs are 16 digits or longer (I don't know if this is the case with these sentrix IDs).

If you have a way of accessing the ID column before it is converted to scientific notation, you could convert the values into strings. You'd do this by just adding a single ' quote at the start of each entry in the column. This forces Excel to accept it as the full ID as it interprets it as a text cell. Excel ignores the first ' character and should still just display the full number. The full number will also be written to any csv/tsv (etc.) files without the leading '.

Not sure if this is applicable or not, but it might help.

@ejh243
Copy link
Owner

ejh243 commented Apr 30, 2024

this can be linked with #50

@sof202
Copy link
Collaborator

sof202 commented Sep 23, 2024

@ew367, solved by #220 right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants