Issue 423 - Propagate SitemapStream error

lib/sitemap-index-stream.ts

@@ -99,6 +99,7 @@ export class SitemapAndIndexStream extends SitemapIndexStream {
     this.getSitemapStream = opts.getSitemapStream;
     [this.idxItem, this.currentSitemap, this.currentSitemapPipeline] =
       this.getSitemapStream(0);
+    this.currentSitemap.on('error', (err) => this.emit('error', err));
     this.limit = opts.limit ?? 45000;
   }
 
@@ -124,6 +125,7 @@ export class SitemapAndIndexStream extends SitemapIndexStream {
       const onFinish = () => {
         const [idxItem, currentSitemap, currentSitemapPipeline] =
           this.getSitemapStream(this.i / this.limit);
+        currentSitemap.on('error', (err) => this.emit('error', err));
         this.currentSitemap = currentSitemap;
         this.currentSitemapPipeline = currentSitemapPipeline;
         // push to index stream

tests/sitemap-index.test.ts

@@ -193,6 +193,12 @@ describe('sitemapAndIndex', () => {
           resolve(join(targetFolder, 'does', 'not', 'exist'), path)
         );
 
+        // Streams do not automatically propagate errors
+        // We must propagate this up to the SitemapStream
+        outputStream.on('error', (err) => {
+          sm.emit('error', err);
+        });
+
         const ws = sm.pipe(outputStream);
         return [new URL(path, baseURL).toString(), sm, ws];
       },
@@ -202,7 +208,10 @@ describe('sitemapAndIndex', () => {
     sms.write('https://3.example.com/a');
     sms.write('https://4.example.com/a');
     sms.end();
-    await finished(sms);
+    await expect(finished(sms)).rejects.toThrow(
+      'ENOENT: no such file or directory, open'
+    );
+
     expect(
       existsSync(
         resolve(join(targetFolder, 'does', 'not', 'exist'), `./sitemap-0.xml`)