Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sagemaker-spaces): add support for Sagemaker Spaces #158

Merged

Conversation

npellegrin
Copy link
Contributor

Closes #157

This PR is a port of rebuy-de/aws-nuke#1197

Output with feature activated

> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID 000000000000 and the alias 'test-account'?
Do you want to continue? Enter account alias to continue.
> test-account

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - would remove
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - would remove
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - would remove
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - would remove
Scan complete: 4 total, 4 nukeable, 0 filtered.

Do you really want to nuke the account with the ID 000000000000 and the alias 'test-account'?
Do you want to continue? Enter account alias to continue.
> test-account

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - triggered remove
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - failed
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - failed
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - triggered remove

Removal requested: 2 waiting, 2 failed, 0 skipped, 0 finished

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - waiting
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - triggered remove
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - failed
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - waiting

Removal requested: 3 waiting, 1 failed, 0 skipped, 0 finished

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - removed
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - waiting
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - triggered remove
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - removed

Removal requested: 2 waiting, 0 failed, 0 skipped, 2 finished

eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - removed
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - waiting

Removal requested: 1 waiting, 0 failed, 0 skipped, 3 finished

eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - waiting

eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - removed

Removal requested: 0 waiting, 0 failed, 0 skipped, 4 finished

Nuke complete: 0 failed, 0 skipped, 4 finished.

@npellegrin npellegrin force-pushed the feature/sagemaker-app-space-userprofile branch from be400f4 to 63aa5fd Compare May 3, 2024 11:01
@npellegrin npellegrin changed the title Add support for Sagemaker Spaces feat(sagemaker-spaces) Add support for Sagemaker Spaces May 3, 2024
@npellegrin npellegrin force-pushed the feature/sagemaker-app-space-userprofile branch from 63aa5fd to 8222e60 Compare May 3, 2024 11:04
@npellegrin npellegrin changed the title feat(sagemaker-spaces) Add support for Sagemaker Spaces feat(sagemaker-spaces): Add support for Sagemaker Spaces May 3, 2024
@npellegrin npellegrin force-pushed the feature/sagemaker-app-space-userprofile branch from 8222e60 to 16e062b Compare May 3, 2024 11:08
@npellegrin npellegrin changed the title feat(sagemaker-spaces): Add support for Sagemaker Spaces feat(sagemaker-spaces): add support for Sagemaker Spaces May 3, 2024
@ekristen
Copy link
Owner

ekristen commented May 3, 2024

Looks great to me! Thanks for taking the time to get the commit and PR title syntax correct along with commit signing.

@ekristen ekristen merged commit 3d24421 into ekristen:main May 3, 2024
6 checks passed
@ekristen
Copy link
Owner

ekristen commented May 3, 2024

🎉 This PR is included in version 3.0.0-beta.47 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ekristen
Copy link
Owner

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SageMaker Space Apps and Spaces
2 participants