Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch for settings and config package from libnuke, improve docs #28

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

ekristen
Copy link
Owner

@ekristen ekristen commented Jan 23, 2024

  • Updates to [email protected]
  • Resources now define their own DeprecatedAliases and AlternativeResource (aka CloudControl API) resource names.
  • Removes more code from aws-nuke in favor of using packages from libnuke
  • Improving documentation around configuration of the tool
  • Replaces the bulk of the config package for the libnuke/pkg/config and extends it with the extras that aws-nuke needs.
  • Deprecates the use of feature-flags in favor of the settings. Documentation has been added on how to migrate. Version 3 is still backwards compatible.
  • General code cleanups and improvements

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@ekristen ekristen merged commit 1674343 into main Jan 23, 2024
1 check passed
@ekristen ekristen deleted the settings branch January 23, 2024 00:59
ekristen added a commit that referenced this pull request Jan 30, 2024
* switch for settings and config package from libnuke, improve docs

* fix: tests

* fix: do not upload to codeconv yet
ekristen added a commit that referenced this pull request Jan 30, 2024
* switch for settings and config package from libnuke, improve docs

* fix: tests

* fix: do not upload to codeconv yet
corybekk pushed a commit to oreillymedia/aws-nuke-v2 that referenced this pull request Nov 4, 2024
corybekk pushed a commit to oreillymedia/aws-nuke-v2 that referenced this pull request Nov 5, 2024
…risten#28)

* switch for settings and config package from libnuke, improve docs

* fix: tests

* fix: do not upload to codeconv yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants