Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automerge-action to upstream, give workflow title #3114

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Update automerge-action to upstream, give workflow title #3114

merged 2 commits into from
Jan 20, 2021

Conversation

michaelbeaumont
Copy link
Contributor

Description

I was waiting on my PR and this PR which have been merged now.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@michaelbeaumont michaelbeaumont added area/build-and-release skip-release-notes Causes PR not to show in release notes labels Jan 20, 2021
@michaelbeaumont michaelbeaumont requested a review from a team January 20, 2021 13:05
aclevername
aclevername approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont merged commit 796aedd into eksctl-io:master Jan 20, 2021
@michaelbeaumont michaelbeaumont deleted the automerge_up branch January 20, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
area/build-and-release skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @aclevername