Fix search results flicker when timeline images are loading #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
force-pushed
the
fix-search-hover-flicker
branch
from
0b5c1f2 to
f1ea2ee
Compare
|
Wow, I didn't even notice that before. Thanks for the note on how to compare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, hovering over a timeline caused the component to suspend, which caused the somewhat global suspense boundary to trigger, replacing all search results with "loading". That was visually distracting and bad. Now every tooltip has its own suspense boundary, event showing a spinner while it is loading.
To nicely compare before and after, add
tokio::time::sleep(std::time::Duration::from_secs(1)).await;somewhere inhandle_api(inhttp/handle.rs).