Fix null values in waiting series
#1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
force-pushed
the
waiting-series-fix
branch
from
d70fc26 to
b395111
Compare
owi92
force-pushed
the
waiting-series-fix
branch
2 times, most recently
from
d88ddcd to
c2b8e18
Compare
owi92
force-pushed
the
waiting-series-fix
branch
from
c2b8e18 to
d48fded
Compare
In #a4bff75a314d04e85f7cd977076550a6dfa5373d I added read- and write-roles to the series API, but didn't allow `null` values. This lead to deserialization errors when creating waiting series. This fix adds the roles as empty arrays.
owi92
force-pushed
the
waiting-series-fix
branch
from
d48fded to
caafabf
Compare
LukasKalbertodt
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a4bff75 I added read and write roles to the series API,
but forgot to explicitly insert them when a new "waiting" series was created. This meant they were added asnullvalues, leading to deserialization issues when trying to use theSeries::createfunction. This fix explicitly adds them in said function as empty arrays.Edit: Turns out I just needed to allow
nullvalues by adding them asOption<role>instead.