ci: set up OIDC in the release workflow #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
previously approved these changes
Sep 16, 2024
.github/workflows/release.yml
Outdated
Comment on lines
19
to
20
| ELASTIC_CDN_PROJECT_ID: ${{ inputs.dry-run == false && 'elastic-cdn-4ae000ab' || 'elastic-observability-ci' }} | ||
| ELASTIC_CDN_PROJECT_NUMBER: ${{ inputs.dry-run == false && '382950469386' || '911195782929' }} |
There was a problem hiding this comment.
There is no way to use one or the other but both?
There was a problem hiding this comment.
Thanks for the hint.
Seems like in existing cases we are only using the project-number.
There was a problem hiding this comment.
The dry-run of that commit was successful here: https://github.com/elastic/apm-agent-rum-js/actions/runs/10879975420
v1v
previously approved these changes
Sep 16, 2024
|
However, we will only determine if it works on the release day. cc @elastic/observablt-ci, @elastic/apm-agent-rum |
reakaleek
commented
Sep 17, 2024
v1v
approved these changes
Sep 17, 2024
vigneshshanmugam
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up keyless authentication to GCP with OIDC.
I have a successful dry-run here: https://github.com/elastic/apm-agent-rum-js/actions/runs/10850931893, which is deploying to a test bucket in the elastic-observability-ci GCP project