Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase benchmark warmup time #15339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericywl
Copy link

@ericywl ericywl commented Jan 23, 2025

Motivation/summary

Fixes #14948

Checklist

N / A

How to test these changes

Run throughput benchmark

@ericywl ericywl requested a review from a team as a code owner January 23, 2025 04:49
Copy link
Contributor

mergify bot commented Jan 23, 2025

This pull request does not have a backport label. Could you fix it @ericywl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 23, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 23, 2025
@ericywl ericywl marked this pull request as draft January 23, 2025 04:53
@ericywl
Copy link
Author

ericywl commented Jan 23, 2025

@rubvs From what I can gather, the benchmark warmup time is configured by BENCHMARK_WARMUP_TIME. Let me know if I missed anything. I will try to run the benchmarks and verify.

@rubvs
Copy link
Contributor

rubvs commented Jan 23, 2025

@ericywl Correct. This should be the only change to make. You can move this out-of-draft and let's get feedback from the rest of the team.

With this issue there isn't much "testing" you can do. I've already concluded this through running many benchmarks. However, this is a great first-issue:

  • It'll force you to read and hopefully improve the docs, see workflow.md in Throughput.
  • Trigger a benchmark in GitHub Actions that run on ESS.
  • Trigger a benchmark from your local machine that runs in ESS.
  • Spot the env var change in the Terraform provisioning logs for confirmation.

@ericywl ericywl marked this pull request as ready for review January 24, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase benchmark warmup time
2 participants