-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip flaky test TestSQSReceiver/ReceiveMessage_success #42245
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
@bturquet can we get someone from your team to review this? |
I had a look into the failing test and the logic it's testing. IMO, this test is important as it validates SQS processing from end to end with mocked processors. So we should not disable this test. The flakiness comes from this gomock stub 1. And the root cause seems to be,
I think we can fix the flakiness by simply changing Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we enable the test again and go with the the proposed change of this comment - #42245 (comment) ?
Proposed commit message
See title
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Disruptive User Impact## Author's Checklist## How to test this PR locallyRelated issues
missing call(s) to *awss3.MockSQSAPI.ReceiveMessage
#41458## Use cases## Screenshots## Logs