Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage your cloud organization #292

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Manage your cloud organization #292

wants to merge 25 commits into from

Conversation

shainaraskas
Copy link
Collaborator

@shainaraskas shainaraskas commented Feb 3, 2025 •
edited
Loading

Edits all pages in the "Manage your Cloud organization" section to meet the new section requirements and add applies tags

Deletes all raw pages now covered by this section

@bmorelli25
Copy link
Member

*updated branch to pull in new ci requirements

@shainaraskas
Copy link
Collaborator Author

shainaraskas commented Feb 4, 2025 •
edited
Loading

blocked by mailto bug

removed my mailtos for now

@shainaraskas shainaraskas requested a review from eedugon February 4, 2025 22:17
@shainaraskas shainaraskas marked this pull request as ready for review February 4, 2025 22:17
@eedugon
Copy link
Contributor

eedugon commented Feb 5, 2025

This is probably a silly comment, and might not have a straight forward solution, but the way this is rendered at serverless-project-billing-dimensions.md:

image

The names look a bit inconsistent considering how serverless projects are named in the UI:

image

One of the names mention Serverless while the others don't, and Observability adds Elastic while Security doesn't.

I'd suggest a quick review at those links together with the 3 navigation_titles of the related pages, at lest to be more homogeneous.

My suggestion would be:

  • Elasticsearch billing dimensions
  • Elastic for Observability billing dimensions
  • Elastic for Security billing dimensions

If we include serverless let's do it in all of them.
If we remove Elastic let's do it for both Observability and Security.

For the left pane navigation menu I'd suggest to align it in the same way.

eedugon
eedugon previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work!
I just shared a few comments for your consideration.

deploy-manage/cloud-organization/service-status.md Outdated Show resolved Hide resolved
deploy-manage/cloud-organization/service-status.md Outdated Show resolved Hide resolved
deploy-manage/toc.yml Show resolved Hide resolved
@shainaraskas @eedugon
Apply suggestions from code review
d365572 
Co-authored-by: Edu González de la Herrán <[email protected]>
@shainaraskas shainaraskas requested a review from eedugon February 6, 2025 19:30
eedugon
eedugon approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eedugon eedugon eedugon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shainaraskas @bmorelli25 @eedugon