Skip reindexing for integration plugins index #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When adding a new integration plugin, the related plugin page in the Logstash ref links to a non-existent VPR docs landing page, causing broken links. Manually adding the landing page to the VPR docs doesn't currently work — it gets overwritten in the next VPR doc gen.
Example of this for an input plugin:
Solution:
Update the
versioned_plugins.rb
to avoid overwriting the integration plugin index in the VPR docs. This lets us manually add landing pages for integration plugins to the VPR docs. However, this means we'll need to manually maintain integrations-index.asciidoc going forward.Testing:
Check out the
main
branch locally.Run
versiond_plugins.rb
to generate the VPR docs:Include a landing page in the
integrations-index.asciidoc
file in the generatedlogstash-docs
repo. The landing page doesn't need to exist. Example:Check out this PR's branch locally.
Rerun
versiond_plugins.rb
script to regenerate the VPR docs. Use the same output path.Verify that
integrations-index.asciidoc
file in the generatedlogstash-docs
repo wasn't overwritten. It should still contain yourinclude
. Example:Related issue:
Closes #89