Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
zmoog committed Sep 30, 2024
1 parent 227d8a5 commit 3109e90
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion shippers/es.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ def _send_dead_letter_index(self, actions: list[Any]) -> list[Any]:

# If no action can be encoded, return original action list as failed
if len(encoded_actions) == 0:
shared_logger.info(f"no actions to forward to dead letter index; returning {len(non_indexed_actions)} non_indexed_actions")
return non_indexed_actions

errors = es_bulk(self._es_client, encoded_actions, **self._bulk_kwargs)
Expand Down
2 changes: 1 addition & 1 deletion tests/handlers/aws/test_integrations.py
Original file line number Diff line number Diff line change
Expand Up @@ -4445,7 +4445,7 @@ def test_es_dead_letter_index_with_excluded_action_error(self) -> None:
elasticsearch_url: "{self.elasticsearch.get_url()}"
es_dead_letter_index: "{dead_letter_index_name}"
es_dead_letter_forward_errors:
- fail_processor_exception
- non_existent_error
ssl_assert_fingerprint: {self.elasticsearch.ssl_assert_fingerprint}
username: "{self.secret_arn}:username"
password: "{self.secret_arn}:password"
Expand Down

0 comments on commit 3109e90

Please sign in to comment.