Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kaiyan-sheng committed Aug 19, 2024
1 parent 52bfd44 commit 72ea229
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
1 change: 0 additions & 1 deletion constraints.txt

This file was deleted.

5 changes: 4 additions & 1 deletion docs/en/aws-deploy-elastic-serverless-forwarder.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,10 @@ NOTE: Only one deployment per region is allowed when using the {aws} console dir
image::images/aws-serverless-forwarder-create-function.png[Create Elastic Serverless Forwarder Lambda function within SAR]
+
. Complete the **Application settings** according to <<aws-serverless-forwarder-define-deploy-parameters>>.
Please specify the parameters even if they already exist in the `config.yaml` file.
You must specify the parameters even if they already exist in the `config.yaml` file. Depends on the input type, at least
one if the parameters `ElasticServerlessForwarderSQSEvents`, `ElasticServerlessForwarderS3SQSEvents`,
`ElasticServerlessForwarderKinesisEvents`, `ElasticServerlessForwarderCloudWatchLogsEvents` should de defined.

. After your settings have been added, click **Deploy**.
. On the Applications page for **serverlessrepo-elastic-serverless-forwarder**, click **Deployments**.
. Refresh the **Deployment history** until you see the `Create complete` status update. It should take around 5 minutes to deploy &mdash; if the deployment fails for any reason, the create events will be rolled back and you will be able to see an explanation for which event failed.
Expand Down
6 changes: 3 additions & 3 deletions tests/scripts/docker/mypy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ docker run \
--rm lint_mypy \
/bin/bash \
-c "pip install --user -U pip
pip install --user -r requirements-lint.txt -c constraints.txt --cache-dir ${docker_pip_cache}
pip install --user -r requirements-tests.txt -c constraints.txt --cache-dir ${docker_pip_cache}
pip install --user -r requirements.txt -c constraints.txt --cache-dir ${docker_pip_cache}
pip install --user -r requirements.txt --cache-dir ${docker_pip_cache}
pip install --user -r requirements-lint.txt --cache-dir ${docker_pip_cache}
pip install --user -r requirements-tests.txt --cache-dir ${docker_pip_cache}
PATH=\${PATH}:\${HOME}/.local/bin/ /bin/bash ./tests/scripts/mypy.sh $*"

0 comments on commit 72ea229

Please sign in to comment.