-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for aws govcloud in dist.sh #510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed coverage is Generated by 🐒 cobertura-action against adcc52d |
aspacca
reviewed
Oct 29, 2023
aspacca
approved these changes
Oct 31, 2023
aspacca
suggested changes
Oct 31, 2023
aspacca
approved these changes
Nov 3, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for publishing elastic serverless forwarder to SAR in AWS GovCloud.
With this PR we are not adding a new config parameter. Instead, we are only checking the given region name to see if it includes
gov
in the name and set the bucket ARN, bucket resource, and a newAWS_OR_AWS_GOV
variable.In
macro.yaml
, we are using%awsOrGov%
which equals toaws
oraws-us-gov
to construct resource/ARN. For example: if the region is not in AWS Gov, thenresource = f"arn:aws:s3:::{bucket_name_and_object_key}"
and if region is in AWS Gov, thenresource = f"arn:aws-us-gov:s3:::{bucket_name_and_object_key}"
.Checklist
CHANGELOG.md
Related issues