-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit ESF docs added by PR #588 #610
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against bcc7d64 |
I'm sorry, I've used what is a false friend related to Italian. "recurring" should be something like "using"
The messages contain the remaining events, the copy, being a copy of those message, contains the remaining events as well :)
I followed that it seemed to me the convention internal to the ESF docs. I might identified the wrong convention. |
Yup, that's always the right approach for smaller updates like this one. Generally we only italicize the first instance of a new term. We avoid capitalizing terms unless they are product names (though we have quite a few exceptions). Sometimes we bend the rule if we are discussing a 3rd party technology that follows a different style. This definitely falls into the category of "stuff only editors care about" :-). Edited: In case it's not clear from my comment, I'll take care of the changes. Just wanted to make sure there wasn't a specific reason why we are following this convention. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Edits the documentation changes added in #588.
Note that I've tried to make some of the sentences more concise and flow better, but might have inadvertently changed the meaning because the meaning was unclear. Please point out any problems that you find.
I have a few questions for reviewers:
What does this PR do?
Ensure that new and changed content adheres to Elastic style, follows English grammar rules, and is easy to understand.
Why is it important?
Good docs make for happy users.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.md
How to test this PR locally
n/a
Related issues