Update Logstash/ES versions being used in the tests #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constanca-m
commented
Apr 17, 2024
| @@ -8,7 +8,7 @@ set -ex | |||
| # delete any __pycache__ folders to avoid hard-to-debug caching issues | |||
| find . -name __pycache__ -type d -exec rm -r '{}' + || true | |||
| PYTEST_ARGS=("${PYTEST_ARGS}") | |||
| py.test -vv "${PYTEST_ARGS[*]}" "${PYTEST_JUNIT}" tests | |||
| py.test -vv "${PYTEST_ARGS[*]}" "${PYTEST_JUNIT}" tests -s | |||
There was a problem hiding this comment.
I am leaving the -s flag here so we can see the logs when make coverage runs. Otherwise, if the tests get stuck again, we have no way to know what is stopping them.
constanca-m
changed the title
gizas
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest PRs all fail the
coverageworkflow.This happens because
test_integrationsneeds to create containers for the tests. The container logstash was getting stuck inwaiting to be ready....Updating the ES and Logstash versions to 7.17.20 solves this issue.