-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag release workflow #690
Conversation
Signed-off-by: constanca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm wondering if we should make the tagging a workflow_dispatch
workflow that one needs to explicitly run. Then we could update the version ahead of the release, and it would be present in pre-release builds and smoke tests. Doesn't need to be addressed in this PR.
Signed-off-by: constanca <[email protected]>
I updated the workflow to only release a new tag if the new version in |
Co-authored-by: Andrew Gizas <[email protected]>
Co-authored-by: Andrew Gizas <[email protected]>
Co-authored-by: Andrew Gizas <[email protected]>
Signed-off-by: constanca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What does this PR do?
The current release workflow was failing with:
Putting the version variable inside
"
to make it a string solves this issue.We also check if the version variable in
version.py
increased. If that is the case, then we create a new release. Otherwise, nothing happens.Checklist
CHANGELOG.md
How to test
As far as I am aware, the only way to test would be by using your own repository. Just do the following:
share/version.py
file there.Then make the commits to check everything is working as expected. You need to update the
version.py
file to trigger the workflow, unless you also change the trigger or make the workflow run manually.It is not possible to test it here, because we would have to update the
version.py
file of ESF, which does not make sense in this case.